Rename "Fork from here" to "Fork from here (dev only)"#9941
Merged
harryalbert merged 1 commit intomasterfrom May 2, 2026
Merged
Rename "Fork from here" to "Fork from here (dev only)"#9941harryalbert merged 1 commit intomasterfrom
harryalbert merged 1 commit intomasterfrom
Conversation
This clarifies that the menu item is only visible in dogfood/dev builds and is not intended for regular users. The distinction between forking from a block vs. from the exact exchange is a dev debugging tool only. Co-Authored-By: Oz <[email protected]>
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
harryalbert
approved these changes
May 2, 2026
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Overview
This PR renames the dogfood-only context menu item from Fork from here to Fork from here (dev only) in both affected terminal menu construction paths. The existing dogfood channel gate and ForkAIConversationFromExactExchange action are unchanged.
Concerns
- No correctness, security, or spec concerns found in the changed lines.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
Contributor
|
|
wolverine2k
pushed a commit
to wolverine2k/warp
that referenced
this pull request
May 5, 2026
Renames the "Fork from here" context menu item to "Fork from here (dev only)" to make it clear this is a dev/dogfood-only debugging tool and not a user-facing feature. This item (which triggers `ForkAIConversationFromExactExchange`) is already gated behind `is_dogfood()`, so it's never shown to preview/stable users. The new label clarifies the intent to anyone on the dogfood channel who sees it. N/A — minor label clarification requested via Slack feedback. - [ ] The linked issue is labeled `ready-to-spec` or `ready-to-implement`. - [x] Where appropriate, screenshots or a short video of the implementation are included below (especially for user-visible or UI changes). Label-only change; no logic changes. The item remains gated behind `ChannelState::channel().is_dogfood()`. - [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode _Conversation: https://staging.warp.dev/conversation/89fa5f8f-458c-4613-9f43-fd1c4f5d0d66_ _Run: https://oz.staging.warp.dev/runs/019deacc-8b29-70d0-a676-c4d591420ba2_ _This PR was generated with [Oz](https://warp.dev/oz)._ Co-authored-by: Oz <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Renames the "Fork from here" context menu item to "Fork from here (dev only)" to make it clear this is a dev/dogfood-only debugging tool and not a user-facing feature.
This item (which triggers
ForkAIConversationFromExactExchange) is already gated behindis_dogfood(), so it's never shown to preview/stable users. The new label clarifies the intent to anyone on the dogfood channel who sees it.Linked Issue
N/A — minor label clarification requested via Slack feedback.
ready-to-specorready-to-implement.Testing
Label-only change; no logic changes. The item remains gated behind
ChannelState::channel().is_dogfood().Agent Mode
Conversation: https://staging.warp.dev/conversation/89fa5f8f-458c-4613-9f43-fd1c4f5d0d66
Run: https://oz.staging.warp.dev/runs/019deacc-8b29-70d0-a676-c4d591420ba2
This PR was generated with Oz.