Fix computer use rejections#9872
Merged
danielpeng2 merged 1 commit intomasterfrom May 2, 2026
Merged
Conversation
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Overview
This PR removes the filter that dropped cancelled action results before prepending completed action results to the next user-submitted request, allowing cancellation/rejection results such as rejected computer-use requests to be sent back to the agent.
Concerns
- No blocking correctness issues found in the changed hunk.
- No security findings identified.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
zerx-lab
pushed a commit
to zerx-lab/warp
that referenced
this pull request
May 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, if you rejected a computer use request, you'd get stuck in the computer use subagent. This is because of a line in https://github.com/warpdotdev/warp-internal/pull/24463 that prevented cancelled actions from being sent in the next request.
I synced with @vkodithala and verified that this line isn't needed for the original fix, so I'm removing.
Linked Issue
ready-to-specorready-to-implement.Screenshots / Videos
https://www.loom.com/share/ea23a90e5db445b0863e993612f817e2
Testing
Tested that: