re-enable AppMutex setting in Inno Setup#9871
Conversation
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR re-enables the Inno Setup AppMutex hook so manual installer runs detect an existing Warp process and prompt the user to close it before setup proceeds. The existing GetAppMutex implementation skips the check for background updates by returning an empty mutex name.
Concerns
- None.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
…otdev#9871) Manual installs now show the standard "close Warp first" dialog instead of proceeding mid-install while warp.exe is still running. The line was guarded by a stale 4/22-release TODO from upstream; removed alongside the comment. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
## Description Wrapping up the TODO in warpdotdev/warp-internal#24859 This prevents manually running the installer while an existing Warp installation is running from erroring
2 participants
Description
Wrapping up the TODO in warpdotdev/warp-internal#24859
This prevents manually running the installer while an existing Warp installation is running from erroring