Add editable keybinding for toggling the conversation details panel.#9837
Add editable keybinding for toggling the conversation details panel.#9837liliwilson merged 2 commits intomasterfrom
Conversation
liliwilson
force-pushed
the
lili/add-keybinding-for-details-panel
branch
from
89ad5df to
c580d8c
Compare
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR adds an editable Warp AI keybinding for toggling the conversation details panel and exposes a keymap context flag when the panel can be shown.
Concerns
- The new terminal action binding is registered for all targets, but the WASM details panel is controlled by workspace-level transcript panel state, so the shortcut can be active while toggling terminal state that is never rendered.
- This is a user-visible keybinding/settings change, but the PR does not include screenshots or a video demonstrating the configured shortcut and panel toggle behavior end to end.
- The changelog entry has a minor typo:
panelcanshould bepanel can.
Verdict
Found: 0 critical, 2 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| app.register_editable_bindings([EditableBinding::new( | ||
| "terminal:toggle_conversation_details_panel", | ||
| "Toggle Conversation Details Panel", | ||
| TerminalAction::ToggleConversationDetailsPanel, |
There was a problem hiding this comment.
There was a problem hiding this comment.
This is true, but not a big deal. On wasm I think it'd be ideal if we changed it so the conversation details panel is rendered the same way (within the pane, with button in pane header)
There was a problem hiding this comment.
Oh actually might still be worth addressing I think because I'm not sure if the keybinding is going to make the button appear active but not render the panel. Just want to make sure it does nothing on wasm
There was a problem hiding this comment.
Done! (It doesn't actually pass WASM clippy without gating this to non-WASM)
| app.register_editable_bindings([EditableBinding::new( | ||
| "terminal:toggle_conversation_details_panel", | ||
| "Toggle Conversation Details Panel", | ||
| TerminalAction::ToggleConversationDetailsPanel, |
There was a problem hiding this comment.
This is true, but not a big deal. On wasm I think it'd be ideal if we changed it so the conversation details panel is rendered the same way (within the pane, with button in pane header)
liliwilson
force-pushed
the
lili/add-keybinding-for-details-panel
branch
from
c580d8c to
a0461e3
Compare
liliwilson
force-pushed
the
lili/add-keybinding-for-details-panel
branch
from
a0461e3 to
74baac9
Compare
…arpdotdev#9837) <!-- Please remember to add your design buddy onto the PR for review, if it contains any UI changes! --> WISOTT. Follows precedent for defining keys in the keymap context and uses existing function for determining whether this keybinding should be active. Defaults to unset - I wasn't sure of a good keybind for this and don't think it warrants a default. <!-- How did you test this change? What automated tests did you add? If you didn't add any new tests, what's your justification for not adding any? --> Ran locally, set a keybinding (cmd + alt + I), and then observed toggle behavior. - [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode <!-- The entries below will be used when constructing a soft-copy of the stable release changelog. Leave blank or remove the lines if no entry in the stable changelog is needed. Entries should be on the same line, without the `{{` `}}` brackets. You can use multiple lines, even of the same type. The valid suffixes are: * NEW-FEATURE: for new, relatively sizable features. Features listed here will likely have docs / social media posts / marketing launches associated with them, so use sparingly. * IMPROVEMENT: for new functionality of existing features. * BUG-FIX: for fixes related to known bugs or regressions. * IMAGE: the image specified by the URL (hosted on GCP) will be added to Dev & Preview releases. For Stable releases, see the pinned doc in the * OZ: Oz-related updates. Use `CHANGELOG-OZ`. At most 4 Oz updates are shown in-app per release. CHANGELOG-NEW-FEATURE: {{text goes here...}} CHANGELOG-IMPROVEMENT: {{text goes here...}} CHANGELOG-BUG-FIX: {{text goes here...}} CHANGELOG-BUG-FIX: {{more text goes here...}} CHANGELOG-IMAGE: {{GCP-hosted URL goes here...}} CHANGELOG-OZ: {{text goes here...}} --> CHANGELOG-IMPROVEMENT: The conversation details panelcan now be opened and closed with a configurable keyboard shortcut.
2 participants
Description
WISOTT. Follows precedent for defining keys in the keymap context and uses existing function for determining whether this keybinding should be active.
Defaults to unset - I wasn't sure of a good keybind for this and don't think it warrants a default.
Testing
Ran locally, set a keybinding (cmd + alt + I), and then observed toggle behavior.
Agent Mode
Changelog Entries for Stable
CHANGELOG-IMPROVEMENT: The conversation details panelcan now be opened and closed with a configurable keyboard shortcut.