Add Left/Right position toggle to vertical tabs panel settings popup by Felipe2194 · Pull Request #9827 · warpdotdev/warp

Felipe2194 · 2026-05-01T17:32:05Z

Summary

Adds a "Position" section (Left / Right segmented control) to the
vertical tabs panel "View options" popup
Clicking "Right" moves the tabs panel to the right side of the
terminal; clicking "Left" restores it to the default left position
Reuses the existing HeaderToolbarChipSelection infrastructure — no
new settings storage needed

Changes

tab_settings.rs — new VerticalTabsPanelSide { Left, Right } enum
action.rs — new SetVerticalTabsPanelSide(VerticalTabsPanelSide)
action
action_tests.rs — test for should_save_app_state_on_action
view.rs — action handler that moves TabsPanel between left/right
items
vertical_tabs.rs — mouse states, helper render function, and
"Position" UI section

Demo

Video-description.mp4

Closes #9825

settings popup

cla-bot · 2026-05-01T17:32:08Z

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @Felipe2194 on file. In order for us to review and merge your code, each contributor must visit https://cla.warp.dev to read and agree to our CLA. Once you have done so, please comment @cla-bot check to trigger another check.

oz-for-oss · 2026-05-01T17:32:17Z

@Felipe2194

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Felipe2194 · 2026-05-01T17:34:31Z

@cla-bot check

cla-bot · 2026-05-01T17:34:35Z

The cla-bot has been summoned, and re-checked this pull request!

oz-for-oss

Overview

This PR adds a Left/Right position segmented control to the vertical tabs settings popup and handles the new action by moving TabsPanel between the header toolbar selection's left and right item lists.

Concerns

The side action is not idempotent for custom toolbar layouts: selecting the side that is already active still removes and reinserts TabsPanel at index 0, which can unexpectedly change a user's custom toolbar order.
This is a user-visible UI change, but the provided PR description does not include screenshots or a video demonstrating the feature end to end. For faster review, please upload visual evidence before approval.
Security pass: no security-sensitive behavior or data exposure concerns were identified in the changed code.

Verdict

Found: 0 critical, 2 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

oz-for-oss · 2026-05-01T17:36:54Z

+                    .clone();
+                let mut left_items = config.left_items();
+                let mut right_items = config.right_items();
+                left_items.retain(|i| i != &HeaderToolbarItemKind::TabsPanel);


⚠️ [IMPORTANT] This action is not idempotent: clicking the already-selected side removes TabsPanel and reinserts it at index 0, clobbering any custom toolbar order. Return early when the panel is already on side, or skip dispatch from the selected segment.

oz-for-oss · 2026-05-01T17:36:54Z

+    )))
+    .finish();
+
+    popup_col.add_child(make_divider(theme));


⚠️ [IMPORTANT] For faster review, please upload screenshots or a video of the feature working end to end.

already on requested side

Felipe2194 · 2026-05-01T17:50:23Z

@cla-bot check

Felipe2194 · 2026-05-01T17:53:35Z

/oz-review

oz-for-oss · 2026-05-01T17:53:47Z

@Felipe2194

I'm re-reviewing this pull request in response to a review request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

oz-for-oss

Overview

Adds a Position control to the vertical-tabs View options popup and routes it through header_toolbar_chip_selection to move the TabsPanel between left and right panel slots.

Concerns

The new Right option does not update side-aware overlay positioning for the View options popup; after moving the panel right, the popup is still anchored as if the button is on the left and can render outward/off-screen.
No screenshots or video were included for this UI-impacting change. For faster review, please upload screenshots or a video of the feature working end to end.
Security pass: no security concerns identified in the changed code.

Verdict

Found: 0 critical, 2 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

oz-for-oss · 2026-05-01T17:59:01Z

                );
                ctx.notify();
            }
+            SetVerticalTabsPanelSide(side) => {


⚠️ [IMPORTANT] When the panel is moved right, Workspace::render still anchors the View options popup with BottomLeft/TopLeft, so it opens outward/off-screen from the right panel; make that popup anchor side-aware before exposing the Right option.

tabs panel is on the right

Felipe2194 · 2026-05-01T18:03:17Z

/oz-review

oz-for-oss · 2026-05-01T18:03:30Z

@Felipe2194

I'm re-reviewing this pull request in response to a review request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

oz-for-oss

Overview

This PR adds a Left/Right position selector to the vertical tabs settings popup and wires it to the existing header toolbar chip selection setting so the vertical tabs panel can move sides.

Concerns

This is a user-visible UI/layout change, but the provided PR description and workflow context do not include screenshots, GIFs, or video showing the feature working end to end. For faster review, please upload screenshots or a video of the feature working end to end.
Security pass: no security concerns found in the changed code.

Verdict

Found: 0 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Felipe2194 · 2026-05-03T20:35:15Z

Added demo screenshot as requested, ready for review

Felipe2194 · 2026-05-03T23:11:15Z

/oz-review

oz-for-oss · 2026-05-03T23:11:27Z

@Felipe2194

I'm re-reviewing this pull request in response to a review request.

You can view the conversation on Warp.

I reviewed this pull request and requested human review from: @zachbai.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Oz no longer requests changes for this pull request after the latest automated review.

oz-for-oss

Overview

This PR adds a Left/Right position control to the vertical tabs settings popup and implements the side change by moving TabsPanel between the existing header toolbar left/right item lists. The security pass did not identify security-relevant changes.

Concerns

The new Position action updates settings without emitting the same vertical-tabs display-option telemetry used by the adjacent settings actions.

Verdict

Found: 0 critical, 0 important, 1 suggestions

Approve with nits

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

oz-for-oss · 2026-05-03T23:22:01Z

+                        right: right_items,
+                    }
+                };
+                TabSettings::handle(ctx).update(ctx, |settings, ctx| {


💡 [SUGGESTION] This is the only vertical-tabs display option action that updates settings without sending VerticalTabsTelemetryEvent::DisplayOptionChanged, so the new Position control will be invisible in feature analytics. Add telemetry for the side change before notifying.

zachbai · 2026-05-04T04:31:33Z

@Felipe2194 thanks for the change.

For changes like this - please open a GH issue to build alignment on the solution prior to opening a PR. Helps us get a sense for how much traction a given feature request has.

For this change in particular, you're already able to move the tabs panel to the right via 'Re-arrange toolbar items' when you right click the top bar, and I'm not sure moving tabs to the right is a common enough config that it needs to be made available in that vertical tab popup, which is pretty crowded as is.

Add Left/Right position toggle to vertical tabs panel

df47bc4

settings popup

github-actions Bot added the external-contributor Indicates that a PR has been opened by someone outside the Warp team. label May 1, 2026

cla-bot Bot added the cla-signed label May 1, 2026

oz-for-oss Bot previously requested changes May 1, 2026

View reviewed changes

Fix: skip SetVerticalTabsPanelSide when panel is

f777f30

already on requested side

oz-for-oss Bot previously requested changes May 1, 2026

View reviewed changes

Fix: make View options popup anchor side-aware when

d985bb9

tabs panel is on the right

oz-for-oss Bot previously requested changes May 1, 2026

View reviewed changes

oz-for-oss Bot reviewed May 3, 2026

View reviewed changes

oz-for-oss Bot requested a review from zachbai May 3, 2026 23:22

Conversation

Felipe2194 commented May 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Demo

Uh oh!

cla-bot Bot commented May 1, 2026

Uh oh!

oz-for-oss Bot commented May 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Felipe2194 commented May 1, 2026

Uh oh!

cla-bot Bot commented May 1, 2026

Uh oh!

oz-for-oss Bot left a comment

Choose a reason for hiding this comment

Overview

Concerns

Verdict

Uh oh!

oz-for-oss Bot May 1, 2026

Choose a reason for hiding this comment

Uh oh!

oz-for-oss Bot May 1, 2026

Choose a reason for hiding this comment

Uh oh!

Felipe2194 commented May 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Felipe2194 commented May 1, 2026

Uh oh!

oz-for-oss Bot commented May 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oz-for-oss Bot left a comment

Choose a reason for hiding this comment

Overview

Concerns

Verdict

Uh oh!

oz-for-oss Bot May 1, 2026

Choose a reason for hiding this comment

Uh oh!

Felipe2194 commented May 1, 2026

Uh oh!

oz-for-oss Bot commented May 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oz-for-oss Bot left a comment

Choose a reason for hiding this comment

Overview

Concerns

Verdict

Uh oh!

Felipe2194 commented May 3, 2026

Uh oh!

Felipe2194 commented May 3, 2026

Uh oh!

oz-for-oss Bot commented May 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oz-for-oss Bot left a comment

Choose a reason for hiding this comment

Overview

Concerns

Verdict

Uh oh!

oz-for-oss Bot May 3, 2026

Choose a reason for hiding this comment

Uh oh!

zachbai commented May 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Felipe2194 commented May 1, 2026 •

edited

Loading

oz-for-oss Bot commented May 1, 2026 •

edited

Loading

Felipe2194 commented May 1, 2026 •

edited

Loading

oz-for-oss Bot commented May 1, 2026 •

edited

Loading

oz-for-oss Bot commented May 1, 2026 •

edited

Loading

oz-for-oss Bot commented May 3, 2026 •

edited

Loading