docs: attribute two more Alacritty-derived files (#9522)#9707
Conversation
Refs warpdotdev#9522. After warpdotdev#9513 and warpdotdev#9563 added attribution headers to the original tranche of derivative files, two more files remain unattributed: - `app/src/terminal/model/grid/grid_storage/resize.rs`: grid resize/reflow logic adapted from `alacritty_terminal/src/grid/resize.rs`. The parent `grid_storage.rs` was attributed in warpdotdev#9513; this child module was missed. - `app/src/terminal/ref_tests/mod.rs`: test harness structure adapted from `alacritty_terminal/tests/ref.rs`, including the `ref_tests!` macro, JSON fixture loading, and the `.alacritty.recording` data format. Both files now carry the same two-line attribution comment pointing to the existing `crates/warp_terminal/src/model/LICENSE-ALACRITTY` (Apache-2.0).
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @MatthewJamisonJS on file. In order for us to review and merge your code, each contributor must visit https://cla.warp.dev to read and agree to our CLA. Once you have done so, please comment |
github-actions
Bot
added
the
external-contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I reviewed this pull request and requested human review from: @warpdotdev/oss-maintainers. Comment Powered by Oz |
|
Hey — thank you for even taking a moment to look at this. I'm relatively new to contributing to open source, and picking this up as one of my first PRs felt meaningful given how the original issue was raised. I did my best to trace the lineage carefully — cross-referencing Alacritty's test harness in If there's anything to adjust, I'm happy to revise. Just grateful for the chance to contribute something, even if it's small. |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR adds Apache-2.0 Alacritty attribution comments to two files that were identified as adapted from alacritty_terminal. The changes are documentation-only and do not alter runtime behavior.
Concerns
- None.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
/oz-review |
|
I'm re-reviewing this pull request in response to a review request. You can view the conversation on Warp. I reviewed this pull request and requested human review from: @warpdotdev/oss-maintainers. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR adds Alacritty/Apache attribution comments to app/src/terminal/model/grid/grid_storage/resize.rs and app/src/terminal/ref_tests/mod.rs without changing executable code.
Concerns
- None. The supplemental security pass found no security-relevant changes.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
vorporeal
left a comment
vorporeal
left a comment
There was a problem hiding this comment.
thank you for catching and updating these two files!
|
my pleasure 🙂🖖🏿 |
MatthewJamisonJS
deleted the
MatthewJamisonJS/attribute-remaining-alacritty-sources
branch
…arpdotdev#9707) ## Description Refs warpdotdev#9522. After warpdotdev#9513 and warpdotdev#9563 added attribution headers to the original set of derivative files, two more files remain unattributed: | File | Upstream origin | | --- | --- | | `app/src/terminal/model/grid/grid_storage/resize.rs` | `alacritty_terminal/src/grid/resize.rs` — grid resize/reflow logic. The parent `grid_storage.rs` was attributed in warpdotdev#9513; this child module was missed. | | `app/src/terminal/ref_tests/mod.rs` | `alacritty_terminal/tests/ref.rs` — test harness, including the `ref_tests!` macro, JSON fixture loading, and the `.alacritty.recording` data format. | Both files now carry the same two-line attribution comment that warpdotdev#9513 and warpdotdev#9563 introduced, pointing to the existing `crates/warp_terminal/src/model/LICENSE-ALACRITTY` (Apache-2.0). ## Linked Issue - [x] The linked issue is labeled `ready-to-spec` or `ready-to-implement`. ## Screenshots / Videos Not applicable — documentation/comments only. ## Testing No code paths changed. `cargo clippy --workspace --all-targets --all-features --tests -- -D warnings` clean. Note: `cargo fmt --check` reports pre-existing import-ordering failures in both files that are present on `master` before this change (confirmed by checking `git stash` baseline). These are not introduced by this PR. ## Agent Mode - [ ] Warp Agent Mode - This PR was created via Warp's AI Agent Mode
2 participants
Description
Refs #9522.
After #9513 and #9563 added attribution headers to the original set of derivative files, two more files remain unattributed:
app/src/terminal/model/grid/grid_storage/resize.rsalacritty_terminal/src/grid/resize.rs— grid resize/reflow logic. The parentgrid_storage.rswas attributed in #9513; this child module was missed.app/src/terminal/ref_tests/mod.rsalacritty_terminal/tests/ref.rs— test harness, including theref_tests!macro, JSON fixture loading, and the.alacritty.recordingdata format.Both files now carry the same two-line attribution comment that #9513 and #9563 introduced, pointing to the existing
crates/warp_terminal/src/model/LICENSE-ALACRITTY(Apache-2.0).Linked Issue
ready-to-specorready-to-implement.Screenshots / Videos
Not applicable — documentation/comments only.
Testing
No code paths changed.
cargo clippy --workspace --all-targets --all-features --tests -- -D warningsclean.Note:
cargo fmt --checkreports pre-existing import-ordering failures in both files that are present onmasterbefore this change (confirmed by checkinggit stashbaseline). These are not introduced by this PR.Agent Mode