docs: attribute Alacritty/vte derivative code in two more files (#9522)#9563
Conversation
The Alacritty maintainer (@chrisduerr) noted in warpdotdev#9522 that, even after warpdotdev#9513 added attribution headers and bundled LICENSE-ALACRITTY, the following files are still verbatim/near-verbatim copies of upstream Alacritty/vte code without notice: - `crates/warp_terminal/src/model/ansi/control_sequence_parameters.rs` almost verbatim of `vte`'s `ansi.rs` module. - `app/src/terminal/grid_renderer/cell_type.rs` (specifically `compute_fg_rgb` at L160, plus the adjacent `compute_bg_rgb` and `get_override_color` helpers — verbatim of alacritty_terminal's color-mapping logic). Add the same two-line "adapted from … under the Apache license" comment header that warpdotdev#9513 introduced, pointing to the existing `crates/warp_terminal/src/model/LICENSE-ALACRITTY` (Apache-2.0 — the same license vte and alacritty_terminal both ship under). For `cell_type.rs` the comment is scoped to the three helpers at the bottom of the file because the surrounding `Secret` / `IsFocused` / `CellType` types are Warp-specific. This is documentation/attribution only — no functional code changes. Refs warpdotdev#9522.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @lonexreb on file. In order for us to review and merge your code, each contributor must visit https://cla.warp.dev to read and agree to our CLA. Once you have done so, please comment |
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I reviewed this pull request and requested human review from: @vorporeal. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR adds attribution comments for Alacritty/vte-derived code in app/src/terminal/grid_renderer/cell_type.rs and crates/warp_terminal/src/model/ansi/control_sequence_parameters.rs. The changed lines are comment-only and do not alter runtime behavior.
Concerns
- No blocking correctness, security, or attribution issues found in the changed lines.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
## Description Refs #9522. After #9513 and #9563 added attribution headers to the original set of derivative files, two more files remain unattributed: | File | Upstream origin | | --- | --- | | `app/src/terminal/model/grid/grid_storage/resize.rs` | `alacritty_terminal/src/grid/resize.rs` — grid resize/reflow logic. The parent `grid_storage.rs` was attributed in #9513; this child module was missed. | | `app/src/terminal/ref_tests/mod.rs` | `alacritty_terminal/tests/ref.rs` — test harness, including the `ref_tests!` macro, JSON fixture loading, and the `.alacritty.recording` data format. | Both files now carry the same two-line attribution comment that #9513 and #9563 introduced, pointing to the existing `crates/warp_terminal/src/model/LICENSE-ALACRITTY` (Apache-2.0). ## Linked Issue - [x] The linked issue is labeled `ready-to-spec` or `ready-to-implement`. ## Screenshots / Videos Not applicable — documentation/comments only. ## Testing No code paths changed. `cargo clippy --workspace --all-targets --all-features --tests -- -D warnings` clean. Note: `cargo fmt --check` reports pre-existing import-ordering failures in both files that are present on `master` before this change (confirmed by checking `git stash` baseline). These are not introduced by this PR. ## Agent Mode - [ ] Warp Agent Mode - This PR was created via Warp's AI Agent Mode
…dotdev#9522) (warpdotdev#9563) ## Description Refs warpdotdev#9522. After warpdotdev#9513 bundled `LICENSE-ALACRITTY` and added attribution headers to the original tranche of derivative files, [@chrisduerr (Alacritty maintainer) followed up](warpdotdev#9522 (comment)) and named two specific files that were still missing attribution: > - This is an almost verbatim copy of VTE's ansi.rs module: > `crates/warp_terminal/src/model/ansi/control_sequence_parameters.rs` > - This function (and several others) are also verbatim copies: > `app/src/terminal/grid_renderer/cell_type.rs:L160` This PR adds the same two-line "adapted from … under the Apache license" comment header that warpdotdev#9513 introduced, pointing to the same bundled `crates/warp_terminal/src/model/LICENSE-ALACRITTY`: | File | Attribution | | ---- | ----------- | | `crates/warp_terminal/src/model/ansi/control_sequence_parameters.rs` | "adapted from the vte crate (an Alacritty project)" — file-wide | | `app/src/terminal/grid_renderer/cell_type.rs` | "color-mapping helpers (`compute_fg_rgb`, `compute_bg_rgb`, `get_override_color`) below are adapted from the alacritty_terminal crate" — scoped because `Secret` / `IsFocused` / `CellType` at the top of the file are Warp-specific | Both files now point to the existing `crates/warp_terminal/src/model/LICENSE-ALACRITTY` (Apache-2.0 — the same license `vte` and `alacritty_terminal` both ship under). No license-file changes are needed. This is documentation/attribution only — no functional changes. ## Scope This PR addresses the **two files explicitly cited** in warpdotdev#9522 by the Alacritty maintainer. The cited comment also says "this function and several others" — the "several others" likely includes the immediately-adjacent `compute_bg_rgb` and `get_override_color` helpers in the same `cell_type.rs` (they are similar verbatim ports), which is why this PR's attribution covers all three of them. A broader audit of files that *might* be derivative beyond what's explicitly cited is best done by Warp's team or the Alacritty maintainers directly, since it requires intimate knowledge of upstream history; happy to extend this PR to cover any additional files that get flagged. ## Testing Documentation/comments only. `cargo fmt -- --check` clean. No code paths affected. ## Server API dependencies - [ ] No server impact. ## Agent Mode - [ ] Warp Agent Mode ## Changelog Entries for Stable (None — internal/legal attribution metadata.)
…arpdotdev#9707) ## Description Refs warpdotdev#9522. After warpdotdev#9513 and warpdotdev#9563 added attribution headers to the original set of derivative files, two more files remain unattributed: | File | Upstream origin | | --- | --- | | `app/src/terminal/model/grid/grid_storage/resize.rs` | `alacritty_terminal/src/grid/resize.rs` — grid resize/reflow logic. The parent `grid_storage.rs` was attributed in warpdotdev#9513; this child module was missed. | | `app/src/terminal/ref_tests/mod.rs` | `alacritty_terminal/tests/ref.rs` — test harness, including the `ref_tests!` macro, JSON fixture loading, and the `.alacritty.recording` data format. | Both files now carry the same two-line attribution comment that warpdotdev#9513 and warpdotdev#9563 introduced, pointing to the existing `crates/warp_terminal/src/model/LICENSE-ALACRITTY` (Apache-2.0). ## Linked Issue - [x] The linked issue is labeled `ready-to-spec` or `ready-to-implement`. ## Screenshots / Videos Not applicable — documentation/comments only. ## Testing No code paths changed. `cargo clippy --workspace --all-targets --all-features --tests -- -D warnings` clean. Note: `cargo fmt --check` reports pre-existing import-ordering failures in both files that are present on `master` before this change (confirmed by checking `git stash` baseline). These are not introduced by this PR. ## Agent Mode - [ ] Warp Agent Mode - This PR was created via Warp's AI Agent Mode
Description
Refs #9522.
After #9513 bundled
LICENSE-ALACRITTYand added attribution headers to the original tranche of derivative files, @chrisduerr (Alacritty maintainer) followed up and named two specific files that were still missing attribution:This PR adds the same two-line "adapted from … under the Apache license" comment header that #9513 introduced, pointing to the same bundled
crates/warp_terminal/src/model/LICENSE-ALACRITTY:crates/warp_terminal/src/model/ansi/control_sequence_parameters.rsapp/src/terminal/grid_renderer/cell_type.rscompute_fg_rgb,compute_bg_rgb,get_override_color) below are adapted from the alacritty_terminal crate" — scoped becauseSecret/IsFocused/CellTypeat the top of the file are Warp-specificBoth files now point to the existing
crates/warp_terminal/src/model/LICENSE-ALACRITTY(Apache-2.0 — the same licensevteandalacritty_terminalboth ship under). No license-file changes are needed.This is documentation/attribution only — no functional changes.
Scope
This PR addresses the two files explicitly cited in #9522 by the Alacritty maintainer. The cited comment also says "this function and several others" — the "several others" likely includes the immediately-adjacent
compute_bg_rgbandget_override_colorhelpers in the samecell_type.rs(they are similar verbatim ports), which is why this PR's attribution covers all three of them. A broader audit of files that might be derivative beyond what's explicitly cited is best done by Warp's team or the Alacritty maintainers directly, since it requires intimate knowledge of upstream history; happy to extend this PR to cover any additional files that get flagged.Testing
Documentation/comments only.
cargo fmt -- --checkclean. No code paths affected.Server API dependencies
Agent Mode
Changelog Entries for Stable
(None — internal/legal attribution metadata.)