Add active_cursor_position to CodeEditorView for IME positioning by qubaitian · Pull Request #9555 · warpdotdev/warp

qubaitian · 2026-04-30T07:02:26Z

Description

Fixes IME candidate window positioning for the code editor on macOS.
CodeEditorView now provides active_cursor_position() so the IME anchor can be derived from the code editor caret instead of falling back to stale positions from other inputs (e.g. terminal input).
Uses current-frame caret geometry with a last-frame fallback to keep placement stable during fast composition/layout timing.

Testing

Manual (macOS):
- Opened a workspace with both a terminal pane and a code editor pane.
- Typed with Chinese IME in terminal first (candidate popup follows terminal caret).
- Switched to code editor and typed with IME; verified candidate popup now anchors near the code editor caret instead of staying at terminal coordinates.
- Repeated with mouse selection/caret moves in the code editor; verified IME popup remains correctly anchored in editor context.
Automated:
- Ran cargo check -p warpui --lib locally after changes.

No new automated tests were added because this bug is tied to macOS IME runtime behavior and AppKit caret query timing (firstRectForCharacterRange) that is difficult to reliably simulate in existing unit/integration test harnesses.

Server API dependencies

Is this change necessary to make the client compatible with a desired server API breaking change?
Does this change rely on a new server API?
- If so, is the use of this API restricted to client channels that rely on the staging server (e.g. WarpDev)?
Is this change enabling the use of a server API on client channels that rely on the production server (e.g. WarpStable)?
- If so, has the new server API been stable on production for at least one server release cycle? See here for more details.

Agent Mode

Warp Agent Mode - This PR was created via Warp's AI Agent Mode

Changelog Entries for Stable

CHANGELOG-NEW-FEATURE: {{text goes here...}}
CHANGELOG-IMPROVEMENT:
CHANGELOG-BUG-FIX: Fix macOS IME candidate popup positioning in code editor panes so it anchors to the editor caret instead of stale terminal/input positions.
CHANGELOG-BUG-FIX:
CHANGELOG-IMAGE: {{GCP-hosted URL goes here...}}
CHANGELOG-OZ: {{text goes here...}}

cla-bot · 2026-04-30T07:02:30Z

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @qubaitian on file. In order for us to review and merge your code, each contributor must visit https://cla.warp.dev to read and agree to our CLA. Once you have done so, please comment @cla-bot check to trigger another check.

oz-for-oss · 2026-04-30T07:02:39Z

@qubaitian

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I reviewed this pull request and requested human review from: @kevinyang372.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

qubaitian · 2026-04-30T07:03:07Z

@cla-bot check

cla-bot · 2026-04-30T07:03:10Z

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @qubaitian on file. In order for us to review and merge your code, each contributor must visit https://cla.warp.dev to read and agree to our CLA. Once you have done so, please comment @cla-bot check to trigger another check.

cla-bot · 2026-04-30T07:03:12Z

The cla-bot has been summoned, and re-checked this pull request!

qubaitian · 2026-04-30T07:06:37Z

@cla-bot check

cla-bot · 2026-04-30T07:06:40Z

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @qubaitian on file. In order for us to review and merge your code, each contributor must visit https://cla.warp.dev to read and agree to our CLA. Once you have done so, please comment @cla-bot check to trigger another check.

cla-bot · 2026-04-30T07:06:42Z

The cla-bot has been summoned, and re-checked this pull request!

oz-for-oss

Overview

This PR adds CodeEditorView::active_cursor_position so macOS IME positioning can query the focused code editor caret using the rich-text render state's saved cursor position.

Concerns

No blocking correctness, security, or performance concerns found in the changed hunk.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

qubaitian · 2026-04-30T07:07:22Z

@cla-bot check

cla-bot · 2026-04-30T07:07:27Z

The cla-bot has been summoned, and re-checked this pull request!

qubaitian · 2026-05-01T15:05:43Z

/oz-review

oz-for-oss · 2026-05-01T15:05:54Z

@qubaitian

I'm re-reviewing this pull request in response to a review request.

You can view the conversation on Warp.

I completed the review and posted feedback on this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

oz-for-oss

Overview

This PR wires CodeEditorView into WarpUI active cursor position reporting so macOS IME anchoring can use the code-editor caret.

Concerns

UI-impacting behavior changes need visual evidence. The PR description includes manual testing notes but no screenshot or video; for faster review, please upload screenshots or a video of the IME candidate popup anchoring to the code editor caret end to end.

Verdict

Found: 0 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

kevinyang372

This worked great! I have one comment on the font size

kevinyang372 · 2026-05-01T18:31:00Z

+    fn active_cursor_position(&self, ctx: &ViewContext<Self>) -> Option<CursorInfo> {
+        let render_state = self.model.as_ref(ctx).render_state().as_ref(ctx);
+        let cursor_id = render_state.saved_positions().cursor_id();
+        let font_size = Appearance::as_ref(ctx).monospace_font_size();


Instead of hard-coding monospace font here, can we use RenderState::styles::base_text::font_size instead?

Done — switched to render_state.styles().base_text.font_size.

…n for IME.

kevinyang372 · 2026-05-01T22:36:13Z

@qubaitian Mind running cargo fmt and re-push? I can merge this after that

qubaitian · 2026-05-02T01:56:55Z

@kevinyang372 Done — ran cargo fmt and pushed.

bot

…pdotdev#9555) ## Description  - Fixes IME candidate window positioning for the code editor on macOS. - `CodeEditorView` now provides `active_cursor_position()` so the IME anchor can be derived from the code editor caret instead of falling back to stale positions from other inputs (e.g. terminal input). - Uses current-frame caret geometry with a last-frame fallback to keep placement stable during fast composition/layout timing. ## Testing  - Manual (macOS): - Opened a workspace with both a terminal pane and a code editor pane. - Typed with Chinese IME in terminal first (candidate popup follows terminal caret). - Switched to code editor and typed with IME; verified candidate popup now anchors near the code editor caret instead of staying at terminal coordinates. - Repeated with mouse selection/caret moves in the code editor; verified IME popup remains correctly anchored in editor context. - Automated: - Ran `cargo check -p warpui --lib` locally after changes. No new automated tests were added because this bug is tied to macOS IME runtime behavior and AppKit caret query timing (`firstRectForCharacterRange`) that is difficult to reliably simulate in existing unit/integration test harnesses. ## Server API dependencies  - [ ] Is this change necessary to make the client compatible with a desired [server API breaking change](https://www.notion.so/warpdev/How-to-safely-introduce-server-API-breaking-changes-0aa805ff5d5d41fd8834f3c95caba0b4?pvs=4#d55ecf8aea3449949d3c33b0e67f6800)? - [ ] Does this change rely on a [new server API](https://www.notion.so/warpdev/How-to-add-a-new-full-stack-feature-8412cede405a4ec194b32bdd4b951035?pvs=4#04da1e6a493542d68b3e998c7d339640)? - [ ] If so, is the use of this API restricted to client channels that rely on the staging server (e.g. WarpDev)? - [ ] Is this change enabling the use of a server API on client channels that rely on the production server (e.g. WarpStable)? - [ ] If so, has the new server API been stable on production for at least one server release cycle? See [here](https://www.notion.so/warpdev/How-to-add-a-new-full-stack-feature-8412cede405a4ec194b32bdd4b951035?pvs=4#73b202f939834b97ab1fbdf7fc82cd53) for more details. ## Agent Mode - [ ] Warp Agent Mode - This PR was created via Warp's AI Agent Mode ## Changelog Entries for Stable  CHANGELOG-NEW-FEATURE: {{text goes here...}} CHANGELOG-IMPROVEMENT: CHANGELOG-BUG-FIX: Fix macOS IME candidate popup positioning in code editor panes so it anchors to the editor caret instead of stale terminal/input positions. CHANGELOG-BUG-FIX: CHANGELOG-IMAGE: {{GCP-hosted URL goes here...}} CHANGELOG-OZ: {{text goes here...}}

Add active_cursor_position to CodeEditorView for IME positioning

eea8137

oz-for-oss Bot reviewed Apr 30, 2026

View reviewed changes

oz-for-oss Bot requested a review from kevinyang372 April 30, 2026 07:07

cla-bot Bot added the cla-signed label Apr 30, 2026

captainsafia added the external-contributor Indicates that a PR has been opened by someone outside the Warp team. label Apr 30, 2026 — with Warp Dev Github Integration

oz-for-oss Bot previously requested changes May 1, 2026

View reviewed changes

kevinyang372 reviewed May 1, 2026

View reviewed changes

Use RenderState.styles().base_text.font_size in active_cursor_positio…

e91f2ec

…n for IME.

kevinyang372 approved these changes May 1, 2026

View reviewed changes

Apply cargo fmt

3bec52d

kevinyang372 merged commit 75bddcc into warpdotdev:master May 2, 2026
22 checks passed

Conversation

qubaitian commented Apr 30, 2026

Description

Testing

Server API dependencies

Agent Mode

Changelog Entries for Stable

Uh oh!

cla-bot Bot commented Apr 30, 2026

Uh oh!

oz-for-oss Bot commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qubaitian commented Apr 30, 2026

Uh oh!

cla-bot Bot commented Apr 30, 2026

Uh oh!

cla-bot Bot commented Apr 30, 2026

Uh oh!

qubaitian commented Apr 30, 2026

Uh oh!

cla-bot Bot commented Apr 30, 2026

Uh oh!

cla-bot Bot commented Apr 30, 2026

Uh oh!

oz-for-oss Bot left a comment

Choose a reason for hiding this comment

Overview

Concerns

Verdict

Uh oh!

qubaitian commented Apr 30, 2026

Uh oh!

cla-bot Bot commented Apr 30, 2026

Uh oh!

qubaitian commented May 1, 2026

Uh oh!

oz-for-oss Bot commented May 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oz-for-oss Bot left a comment

Choose a reason for hiding this comment

Overview

Concerns

Verdict

Uh oh!

kevinyang372 left a comment

Choose a reason for hiding this comment

Uh oh!

kevinyang372 May 1, 2026

Choose a reason for hiding this comment

Uh oh!

qubaitian May 1, 2026

Choose a reason for hiding this comment

Uh oh!

kevinyang372 commented May 1, 2026

Uh oh!

qubaitian commented May 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

oz-for-oss Bot commented Apr 30, 2026 •

edited

Loading

oz-for-oss Bot commented May 1, 2026 •

edited

Loading

qubaitian commented May 2, 2026 •

edited

Loading