Fix copy keybinding to prioritize input text over selected blocks (APP-4330)#9491
Merged
seemeroland merged 1 commit intomasterfrom May 4, 2026
Merged
Fix copy keybinding to prioritize input text over selected blocks (APP-4330)#9491seemeroland merged 1 commit intomasterfrom
seemeroland merged 1 commit intomasterfrom
Conversation
Previously, when a block was selected and the user had highlighted text in the input editor, hitting Ctrl/Cmd-Shift-C copied the block content instead of the selected input text. Both selections can coexist, and the user almost always intends to copy the actively selected input. Update TerminalView::copy to check for selected input text right before falling back to copying selected blocks. Linear: APP-4330 Co-Authored-By: Oz <[email protected]>
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and posted feedback on this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Overview
This PR updates TerminalView::copy so selected input editor text is copied before falling back to selected blocks, while preserving the existing higher-priority CLI subagent, cloud error, and terminal grid selection behavior.
Concerns
- No correctness or security concerns found in the changed diff lines.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
tylerlam-warp
approved these changes
May 1, 2026
wolverine2k
pushed a commit
to wolverine2k/warp
that referenced
this pull request
May 5, 2026
…P-4330) (warpdotdev#9491) ## Description Fixes [APP-4330](https://linear.app/warp/issue/APP-4330): the global Copy keybinding (Ctrl/Cmd-Shift-C) was copying selected block content even when the user had text highlighted in the input editor. You can have a block selected and text highlighted in the input editor at the same time. In that case, the user almost always intends to copy the actively-selected input text, not the block. This change updates `TerminalView::copy` to check for selected text in the input editor before falling back to copying selected blocks. The priority is now: 1. Selected text in CLI subagent views (unchanged) 2. Selected text in the cloud mode error screen (unchanged) 3. Selected text in the terminal grid / block (unchanged) 4. **Selected text in the input editor (new)** 5. Selected blocks (unchanged) ## Testing Manual testing: - Select a block (block card is highlighted) AND highlight text in the input editor. - Press Ctrl/Cmd-Shift-C. - Confirm the highlighted input text is copied to the clipboard, not the block contents. - Confirm copying still works as before when only a block is selected, when only block grid text is selected, etc. https://www.loom.com/share/573b5d4a75ca42a8ad6c40900363edbd ## Server API dependencies N/A — client-only change. ## Agent Mode - [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode ## Changelog Entries for Stable CHANGELOG-BUG-FIX: Copy keybinding now prioritizes selected text in the input over a selected block when both are active. Co-authored-by: Oz <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes APP-4330: the global Copy keybinding (Ctrl/Cmd-Shift-C) was copying selected block content even when the user had text highlighted in the input editor.
You can have a block selected and text highlighted in the input editor at the same time. In that case, the user almost always intends to copy the actively-selected input text, not the block.
This change updates
TerminalView::copyto check for selected text in the input editor before falling back to copying selected blocks. The priority is now:Testing
Manual testing:
https://www.loom.com/share/573b5d4a75ca42a8ad6c40900363edbd
Server API dependencies
N/A — client-only change.
Agent Mode
Changelog Entries for Stable
CHANGELOG-BUG-FIX: Copy keybinding now prioritizes selected text in the input over a selected block when both are active.