Fix typos and example reference in crate READMEs#9408
Fix typos and example reference in crate READMEs#9408captainsafia merged 1 commit intowarpdotdev:masterfrom
Conversation
- crates/warpui_core/README.md
- "to do describe" -> "To describe"
- "appearence" -> "appearance"
- "precicely" -> "precisely"
- "handlign" -> "handling"
- crates/lsp/README.md
- "implmentation" -> "implementation"
- "See main.rs" was ambiguous (no main.rs in src/); point at the
actual example file at examples/rust-lsp/main.rs.
Doc-only.
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I approved this pull request. No matching stakeholder was found for the changed files, so no human reviewers were requested. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR fixes typos in crate README documentation and clarifies the LSP example reference to the existing examples/rust-lsp/main.rs file.
Concerns
- No correctness, security, or documentation concerns found in the changed lines.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
|
@anshul-garg27 Thanks for these contributions! If you'd like to dive into some of the code, we've got a few bugs marked as |
|
Thanks @captainsafia! Already on it — #9412 is a fix for the GitDiffStats flicker from #9228 (currently working through Oz's review feedback). Have a few more code-level fixes in flight that I'll be opening over the next day or two from the ready-to-implement queue. |
captainsafia
added
the
external-contributor
Warp Dev Github Integration
### Description Two README files in \`crates/\` had typos and one had an ambiguous file reference: **\`crates/warpui_core/README.md\`** - \"to do describe\" → \"To describe\" - \"appearence\" → \"appearance\" - \"precicely\" → \"precisely\" - \"handlign\" → \"handling\" **\`crates/lsp/README.md\`** - \"implmentation\" → \"implementation\" - The README said \"See main.rs for an example implementation\" but there is no \`main.rs\` in \`crates/lsp/src/\`. The example actually lives at \`crates/lsp/examples/rust-lsp/main.rs\`, so I made the path explicit. Doc-only changes. ### Testing Markdown only. ### Server API No server changes. ### Agent Mode Not applicable. ### Changelog Entries None. Co-authored-by: anshul-garg27 <[email protected]>
2 participants
Description
Two README files in `crates/` had typos and one had an ambiguous file reference:
`crates/warpui_core/README.md`
`crates/lsp/README.md`
Doc-only changes.
Testing
Markdown only.
Server API
No server changes.
Agent Mode
Not applicable.
Changelog Entries
None.