Update env_vars README to match current file layout#9407
Merged
captainsafia merged 1 commit intowarpdotdev:masterfrom Apr 30, 2026
Merged
Update env_vars README to match current file layout#9407captainsafia merged 1 commit intowarpdotdev:masterfrom
captainsafia merged 1 commit intowarpdotdev:masterfrom
Conversation
Three files referenced in the env_vars README have been moved or renamed since the doc was last updated (the README itself notes "up-to-date as of 6/26/2024"): - update_manager.rs lives under server/cloud_objects/, not server/ - command_dialog/view.rs is now command_dialog/command_dialog_view.rs - section_headers_and_footers.rs is now fixed_view_components.rs The descriptions still match the actual file contents — only the filenames changed.
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I approved this pull request. No matching stakeholder was found for the changed files, so no human reviewers were requested. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Overview
This PR updates stale file path references in app/src/env_vars/README.md to match the current source layout for server update management and env var UI files.
Concerns
- No blocking concerns found.
- Security pass: this is a markdown-only documentation update and does not introduce security-impacting behavior.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
captainsafia
approved these changes
Apr 30, 2026
captainsafia
added
the
external-contributor
Warp Dev Github Integration
wolverine2k
pushed a commit
to wolverine2k/warp
that referenced
this pull request
May 5, 2026
### Description
The env_vars README ("up-to-date as of 6/26/2024") still references
three filenames that have moved or been renamed in the meantime. The
prose description of each file still matches the actual contents — only
the filenames changed.
| README path | Actual path |
|---|---|
| \`app/src/server/update_manager.rs\` |
\`app/src/server/cloud_objects/update_manager.rs\` |
| \`command_dialog/view.rs\` | \`command_dialog/command_dialog_view.rs\`
|
| \`section_headers_and_footers.rs\` | \`fixed_view_components.rs\`
(still defines \`render_trash_banner\` and \`render_save_button\`) |
I deliberately left the rest of the README alone — the other paths it
points at all still exist (verified locally with \`test -f\`).
### Testing
Markdown only — nothing to run.
### Server API
No server changes.
### Agent Mode
Not applicable.
### Changelog Entries
None.
Co-authored-by: anshul-garg27 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The env_vars README ("up-to-date as of 6/26/2024") still references three filenames that have moved or been renamed in the meantime. The prose description of each file still matches the actual contents — only the filenames changed.
I deliberately left the rest of the README alone — the other paths it points at all still exist (verified locally with `test -f`).
Testing
Markdown only — nothing to run.
Server API
No server changes.
Agent Mode
Not applicable.
Changelog Entries
None.