add hook for file editing#9324
Conversation
|
I'm starting a first review of this pull request. You can follow along in the session on Warp. I completed the review and posted feedback on this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR adds an Oz SDK driver hook that records successful file-edit results into the snapshot declarations file, filters file declarations covered by repo declarations, and adds tests/specs for the new snapshot behavior.
Concerns
- The new repo-overlap filter compares declaration paths without normalizing them first, so valid absolute paths containing
..can be dropped as repo-covered even when their normalized location is outside the repo.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| } | ||
| let file_path = Path::new(&entry.path); | ||
| for repo in &repo_paths { | ||
| if file_path.starts_with(repo) { |
There was a problem hiding this comment.
/workspace/repo/../outside.log is currently treated as covered by /workspace/repo and gets dropped even though it resolves outside the repo.
There was a problem hiding this comment.
I don't think we need this, as the agent is setting the file path and it uses absolute paths
harryalbert
force-pushed
the
harry/remote-1465-add-oz-file-editcreation-hooks-for-better-snapshotting
branch
from
5054891 to
b84b12c
Compare
harryalbert
force-pushed
the
harry/remote-1465-add-oz-file-editcreation-hooks-for-better-snapshotting
branch
from
b84b12c to
1bc8dc0
Compare
harryalbert
force-pushed
the
harry/remote-1465-add-oz-file-editcreation-hooks-for-better-snapshotting
branch
from
1bc8dc0 to
30b11c8
Compare
harryalbert
deleted the
harry/remote-1465-add-oz-file-editcreation-hooks-for-better-snapshotting
branch
2 participants
Migrated from /Users/harryalbert/warp-external via
script/migrate-private-to-public.Commits