remove slow filesystem operations for WSL sessions#10240
remove slow filesystem operations for WSL sessions#10240
Conversation
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR avoids slow filesystem probes for WSL sessions by moving the active-session directory existence check into the shell-launch-data branch and by avoiding read_link for non-drive WSL paths.
Concerns
- WSL sessions whose cwd is under
/mnt/<drive>/...now skipis_dir()even though those paths convert to native Windows drive paths, so deleted directories can be treated as valid startup directories.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| // Use Path::is_dir() to validate the path is still valid, | ||
| // e.g. hasn't been deleted, but skip this check in WSL | ||
| // because the WSL filesystem bridge is too slow. | ||
| ShellLaunchData::WSL { .. } => true, |
There was a problem hiding this comment.
/mnt/<drive>/... paths that convert to native Windows drives instead of the slow \\WSL$ bridge; keep validating those native paths so deleted directories are not returned as valid startup directories.
1 participant
Description
9920
Linked Issue
ready-to-specorready-to-implement.Screenshots / Videos
Testing
Agent Mode