spec: refresh repo metadata after claude --worktree (#10031)#10230
Open
lonexreb wants to merge 1 commit intowarpdotdev:masterfrom
Open
spec: refresh repo metadata after claude --worktree (#10031)#10230lonexreb wants to merge 1 commit intowarpdotdev:masterfrom
lonexreb wants to merge 1 commit intowarpdotdev:masterfrom
Conversation
Contributor
github-actions
Bot
added
the
external-contributor
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Overview
This spec defines a CWD-driven repo context refresh for git worktree/repo transitions and metadata clearing when a pane leaves a git repo.
Concerns
- The throttle acceptance criterion conflicts with the behavior contract if top-level and git-common-dir are derived with separate
git rev-parseinvocations.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
Comment on lines
+52
to
+53
| - A5. Throttle: rapid back-and-forth `cd` does not spawn more | ||
| than 2 `git rev-parse` per second. |
Contributor
There was a problem hiding this comment.
git rev-parse commands per derivation, so this limit is internally inconsistent with a 500ms throttle unless both values come from one process. Specify the intended budget in commands vs derivations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec for #10031. CWD-tracking hook gains a 'repo-root changed' signal driven by (toplevel, git-common-dir) tuple change. Existing repo-metadata subsystem refreshes on event. Throttled to 2/sec/pane. Clears metadata when CWD leaves a git repo.
Closes (spec-only) #10031.