spec: tab configs specify agent profile (#10171)#10229
spec: tab configs specify agent profile (#10171)#10229lonexreb wants to merge 1 commit intowarpdotdev:masterfrom
Conversation
github-actions
Bot
added
the
external-contributor
|
Thanks for writing this up. A few details seem worth aligning with the issue thread before this spec lands:
|
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This spec adds a profile field for agent-typed tab-config panes and covers core parsing, defaulting, UI picker, round-trip, and missing-profile behavior.
Concerns
- The spec needs to define the trust/consent model before a tab config can switch an Agent Mode pane to a named profile and dispatch input under that profile.
- The missing-profile "one-time toast" behavior is underspecified.
- The test plan should explicitly cover the ordering guarantee that profile application completes before any initial agent input is dispatched.
Security
- A shared or imported tab config can select a high-autonomy profile by display name before agent input runs; the spec should state the user-visible disclosure or confirmation behavior for this privilege-affecting binding.
Verdict
Found: 0 critical, 2 important, 1 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| type = "agent" | ||
| profile = "Coder devbox" | ||
| ``` | ||
| - B2. When the tab config opens, the named profile is applied to |
There was a problem hiding this comment.
| - B2. When the tab config opens, the named profile is applied to | ||
| the pane before any agent input is dispatched. The profile | ||
| lookup is by display name; if no matching profile exists, the | ||
| pane opens with the default profile and a one-time toast warns |
There was a problem hiding this comment.
| ## Test plan | ||
|
|
||
| - T1. Schema round-trip with the new field. | ||
| - T2. Open path applies the named profile when present. |
There was a problem hiding this comment.
💡 [SUGGESTION] Add a test where the agent pane has initial input and assert the selected profile is applied before that input is dispatched.
2 participants
Spec for #10171. New
profilefield on agent-typed panes in tab configs. When the tab opens, the named profile is applied before any agent input is dispatched. Missing profile = default + one-time toast.Closes (spec-only) #10171.