spec: toolbelt buttons on collapsed conversation blocklist items (#9810)#10227
spec: toolbelt buttons on collapsed conversation blocklist items (#9810)#10227lonexreb wants to merge 1 commit intowarpdotdev:masterfrom
Conversation
github-actions
Bot
added
the
external-contributor
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This spec proposes a collapsed-row toolbelt for conversation blocklist items, including Fork and overflow link-copy actions.
Concerns
- The new spec file does not follow the repo's
PRODUCT.md/TECH.mdspec layout, which can make the approved behavior invisible to the implementation/spec-context workflow. - The keyboard behavior is underspecified and internally unclear for the new Fork and kebab controls.
Verdict
Found: 0 critical, 2 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| @@ -0,0 +1,74 @@ | |||
| # Spec: Toolbelt buttons on collapsed conversation blocklist items (GH-9810) | |||
There was a problem hiding this comment.
PRODUCT.md and, when needed, TECH.md under the ticket directory; adding SPEC.md is likely to be missed by implementation/spec-context tooling. Rename this to the appropriate conventional spec file(s) or state why this exception is intentional.
| - B6. Keyboard: Tab/Shift-Tab moves focus between rows; pressing | ||
| Enter on the kebab opens it; arrow keys navigate within. |
There was a problem hiding this comment.
1 participant
Spec for #9810. Inline toolbelt on collapsed conversation rows: primary Fork button + kebab overflow (copy conversation/share/debug link). Right-click on the row also opens the kebab menu (per @david). Modal-open hides the inline toolbelt to avoid duplication.
Closes (spec-only) #9810.