spec: open review panel maximised by default (#10036)#10223
spec: open review panel maximised by default (#10036)#10223lonexreb wants to merge 1 commit intowarpdotdev:masterfrom
Conversation
github-actions
Bot
added
the
external-contributor
|
I'm starting a first review of this spec-only pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This spec defines a default-off setting to open the code-review panel maximised in one click while preserving the current default behavior. The behavior and acceptance criteria are mostly clear, and the security review found no material high-level security concerns for this UI preference.
Concerns
- The setting key is specified as
editor.review_panel_open_maximized, but the referenced code-review/editor settings in this repository use thecode.editor.*TOML namespace. The spec should name the final TOML path consistently before implementation. - The test plan omits coverage for the runtime-toggle behavior required by A3.
Verdict
Found: 0 critical, 1 important, 1 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
|
|
||
| ## Behavior contract | ||
|
|
||
| - B1. New setting `editor.review_panel_open_maximized: bool`, |
There was a problem hiding this comment.
code.editor.show_code_review_button, code.editor.show_code_review_diff_stats, code.editor.auto_open_code_review_pane_on_first_agent_change). Specify code.editor.review_panel_open_maximized consistently, or explicitly justify the new top-level editor.* namespace, so implementation and TOML round-trip behavior are unambiguous.
|
|
||
| ## Test plan | ||
|
|
||
| - T1. Setting round-trips through TOML. |
There was a problem hiding this comment.
💡 [SUGGESTION] Add a test for A3 so toggling the setting while a non-maximised panel is already open is verified not to mutate the current panel state.
1 participant
Spec for #10036. New
editor.review_panel_open_maximizedboolean setting (default false). When enabled, clicking the code-review button opens the panel pre-maximised in one click. Default-off preserves today's behavior exactly.Closes (spec-only) #10036.