Skip to content

Resolve Warp version via helper script in /feedback skill#10219

Merged
captainsafia merged 1 commit intowarpdotdev:masterfrom
SagarSDagdu:sagar/feedback-version-resolver-script
May 6, 2026
Merged

Resolve Warp version via helper script in /feedback skill#10219
captainsafia merged 1 commit intowarpdotdev:masterfrom
SagarSDagdu:sagar/feedback-version-resolver-script

Conversation

@SagarSDagdu
Copy link
Copy Markdown
Contributor

@SagarSDagdu SagarSDagdu commented May 6, 2026

Description

The /feedback skill has been recording Warp version as Unknown even on packaged builds where the bundled metadata is present (#10214). The skill's references/platforms.md told the agent to read ../../metadata/version.json directly via prose, which is brittle: the agent runtime doesn't always surface adjacent skill resources, and the model can also skip a prose-only lookup.

This PR replaces the prose-only instruction with a scripts/resolve_warp_version.py helper that resolves the metadata path relative to its own location (__file__) and prints {"warp_version": "..."} as JSON when the file is present, or {} when it's missing. references/platforms.md is updated to invoke the helper, mirroring the existing resolve_platform.py pattern already used for OS resolution. The script always exits 0 so the agent treats an empty result as "version unknown" without having to interpret a non-zero exit code.

Linked Issue

Fixes #10214

  • The linked issue is labeled ready-to-spec or ready-to-implement.

(Issue is labeled bug / triaged; no spec label, but the fix is small and mechanical.)

Testing

Manually exercised both branches of the script from the repo root:

$ python3 resources/bundled/skills/feedback/scripts/resolve_warp_version.py
{}
$ mkdir -p resources/bundled/metadata && \
  printf '{\n  "warp_version": "v0.2026.05.06.01.23.stable_99"\n}\n' > resources/bundled/metadata/version.json && \
  python3 resources/bundled/skills/feedback/scripts/resolve_warp_version.py
{"warp_version": "v0.2026.05.06.01.23.stable_99"}

Documentation/script-only change: cargo fmt / cargo clippy / Rust tests not applicable.

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

CHANGELOG-BUG-FIX: Fixed /feedback recording "Unknown" instead of the installed Warp version on packaged builds.

@cla-bot cla-bot Bot added the cla-signed label May 6, 2026
@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented May 6, 2026

@SagarSDagdu

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I reviewed this pull request and requested human review from: @warpdotdev/oss-maintainers.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@github-actions github-actions Bot added the external-contributor Indicates that a PR has been opened by someone outside the Warp team. label May 6, 2026
@captainsafia captainsafia self-requested a review May 6, 2026 03:32
Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR replaces prose-only Warp version lookup guidance in the /feedback skill with a bundled helper script that resolves bundled/metadata/version.json relative to the script location and updates the platform reference to invoke it.

Concerns

  • No blocking correctness, error-handling, or security concerns found in the annotated diff.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@oz-for-oss oz-for-oss Bot requested a review from a team May 6, 2026 03:38
Replaces the prose-only "read ../../metadata/version.json" instruction
with a `scripts/resolve_warp_version.py` helper that resolves the
metadata path relative to its own location and prints the version as
JSON, mirroring the existing `resolve_platform.py` pattern. This makes
version capture deterministic instead of dependent on the agent runtime
surfacing adjacent skill resources, which addresses warpdotdev#10214 where the
filed issue's `Warp version` field landed as `Unknown`.

Fixes warpdotdev#10214
@SagarSDagdu SagarSDagdu force-pushed the sagar/feedback-version-resolver-script branch from 27753cd to c673556 Compare May 6, 2026 03:39
Copy link
Copy Markdown
Contributor

@captainsafia captainsafia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this PR so quickly in response to the original issue! This lines up with my expectation of what the fix should be.

@SagarSDagdu
Copy link
Copy Markdown
Contributor Author

@captainsafia I think you will need to kickoff the workflows for this to be merged?

@captainsafia captainsafia enabled auto-merge (squash) May 6, 2026 04:02
@captainsafia captainsafia merged commit d7206a5 into warpdotdev:master May 6, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed external-contributor Indicates that a PR has been opened by someone outside the Warp team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

/feedback skill records Warp version as Unknown instead of the installed version

2 participants