Resolve Warp version via helper script in /feedback skill#10219
Conversation
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I reviewed this pull request and requested human review from: Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR replaces prose-only Warp version lookup guidance in the /feedback skill with a bundled helper script that resolves bundled/metadata/version.json relative to the script location and updates the platform reference to invoke it.
Concerns
- No blocking correctness, error-handling, or security concerns found in the annotated diff.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
Replaces the prose-only "read ../../metadata/version.json" instruction with a `scripts/resolve_warp_version.py` helper that resolves the metadata path relative to its own location and prints the version as JSON, mirroring the existing `resolve_platform.py` pattern. This makes version capture deterministic instead of dependent on the agent runtime surfacing adjacent skill resources, which addresses warpdotdev#10214 where the filed issue's `Warp version` field landed as `Unknown`. Fixes warpdotdev#10214
27753cd to
c673556
Compare
captainsafia
left a comment
There was a problem hiding this comment.
Thanks for opening this PR so quickly in response to the original issue! This lines up with my expectation of what the fix should be.
|
@captainsafia I think you will need to kickoff the workflows for this to be merged? |
Description
The
/feedbackskill has been recordingWarp versionasUnknowneven on packaged builds where the bundled metadata is present (#10214). The skill'sreferences/platforms.mdtold the agent to read../../metadata/version.jsondirectly via prose, which is brittle: the agent runtime doesn't always surface adjacent skill resources, and the model can also skip a prose-only lookup.This PR replaces the prose-only instruction with a
scripts/resolve_warp_version.pyhelper that resolves the metadata path relative to its own location (__file__) and prints{"warp_version": "..."}as JSON when the file is present, or{}when it's missing.references/platforms.mdis updated to invoke the helper, mirroring the existingresolve_platform.pypattern already used for OS resolution. The script always exits 0 so the agent treats an empty result as "version unknown" without having to interpret a non-zero exit code.Linked Issue
Fixes #10214
ready-to-specorready-to-implement.(Issue is labeled
bug/triaged; no spec label, but the fix is small and mechanical.)Testing
Manually exercised both branches of the script from the repo root:
Documentation/script-only change:
cargo fmt/cargo clippy/ Rust tests not applicable.Agent Mode
CHANGELOG-BUG-FIX: Fixed /feedback recording "Unknown" instead of the installed Warp version on packaged builds.