Add verify-ui-change-in-cloud and test-warp-ui bundled skills (dogfood-gated)#10203
Add verify-ui-change-in-cloud and test-warp-ui bundled skills (dogfood-gated)#10203cephalonaut merged 1 commit intomasterfrom
Conversation
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR adds two dogfood-gated bundled skills for cloud-based UI verification. The workflow is directionally useful, but the current instructions would not run in the target repository and include an unsafe secret-passing pattern.
Concerns
verify-ui-change-in-cloudonly recognizeswarp-internalandwarp-external, so it stops when run from thewarpdotdev/warprepository where this PR lands.test-warp-uiexpandsSTAGING_USER_WARP_API_KEYinto--api-key, which exposes the key in process arguments; use the supportedWARP_API_KEYenvironment variable instead and update the repeated example.
Security
- Passing the staging API key via
--api-keyexposes it through process argv for bothcargoand the launched app.
Verdict
Found: 0 critical, 3 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| Launch Warp from the repository root with: | ||
|
|
||
| ```bash | ||
| cargo run -- --api-key $STAGING_USER_WARP_API_KEY |
There was a problem hiding this comment.
--api-key exposes it in process argv for cargo and Warp; use WARP_API_KEY=$STAGING_USER_WARP_API_KEY cargo run instead.
|
|
||
| Call the `computer_use` tool with a task description that includes: | ||
|
|
||
| - The command to build and launch Warp (typically `cargo run -- --api-key $STAGING_USER_WARP_API_KEY` from the repo root) |
There was a problem hiding this comment.
WARP_API_KEY=$STAGING_USER_WARP_API_KEY cargo run so the key is not passed as a command-line argument.
| - **warp-external** (remote URL contains `warpdotdev/warp-external`): | ||
| - Environment: `zCOubHZzfNWbqgxhiEqdC1` (the warp-external Dev Environment) | ||
|
|
||
| If the remote URL does not match either repository, warn the user that this skill only supports warp-internal and warp-external and stop. |
There was a problem hiding this comment.
warpdotdev/warp, but the detection only accepts warp-internal or warp-external, so the skill stops in the repo where it ships; add a warpdotdev/warp mapping or match the actual dogfood remote.
cephalonaut
force-pushed
the
matthew/verify-ui-change-in-cloud
branch
2 times, most recently
from
d085dab to
21b0710
Compare
…d-gated) Add two new bundled skills gated to dogfood (Local/Dev) builds: - verify-ui-change-in-cloud: spawns a cloud agent with computer use to verify user-facing client changes after they are made - test-warp-ui: guides a cloud agent through launching Warp and testing UI behavior using the computer_use tool Co-Authored-By: Oz <[email protected]>
cephalonaut
force-pushed
the
matthew/verify-ui-change-in-cloud
branch
from
21b0710 to
874e497
Compare
2 participants
Description
Add two new bundled skills gated to dogfood (Local/Dev) builds via
resources/channel-gated-skills/dogfood/:run_agentsto verify the change visually. Detects the current repo (warp-internal or warp-external) and selects the correct environment.cargo runand testing UI behavior using thecomputer_usetool. Used by the cloud agent spawned by verify-ui-change-in-cloud.No Rust code changes — both skills are auto-discovered by the channel-gated build system.
Testing
cargo test -p aipasses (skill parsing tests)Agent Mode
Co-Authored-By: Oz [email protected]