Avoid parallel precheck execution#10188
Merged
kevinyang372 merged 1 commit intomasterfrom May 5, 2026
Merged
Conversation
Contributor
|
I'm starting a first review of this pull request. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
MaggieShan
approved these changes
May 5, 2026
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Overview
This PR changes the remote-server precheck probes from a futures::join! concurrent execution to sequential awaits so the SSH ControlMaster is not asked to service multiple precheck commands at once.
Concerns
- No blocking correctness, error-handling, performance, or security concerns found in the changed lines.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We were running three steps in parallel with
futures::join!This will end up using 3 control master connections. Since each connection is a limited resource, this could cause these open failed issues.
For now I am moving these to be sequential. I considered combining them into one command and have some client side parsing to reconstruct the results but I am not confident about that change with different shells and potential error states. We could observe if latency with sequential execution becomes a problem and decide if we want to further optimize