Reserve titlebar space for right-side window controls#10178
Reserve titlebar space for right-side window controls#10178gabrimatic wants to merge 1 commit intowarpdotdev:masterfrom
Conversation
github-actions
Bot
added
the
external-contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR reserves right-side titlebar control space whenever window controls are on the right, and adds unit coverage for the helper that decides whether tab-bar space should be reserved.
Concerns
- This is a user-visible titlebar layout change, but the PR does not include screenshots or a video showing the Windows/Linux titlebar spacing. For faster review, please upload screenshots or a video of the feature working end to end.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR changes tab-bar layout so right-side custom window controls always reserve space while left-side controls retain the existing behavior, with direct unit coverage for the new helper.
Concerns
- This is a user-visible titlebar layout change, but the PR does not include screenshots or a short video. For faster review, please upload screenshots or a video showing the Windows/Linux titlebar controls and toolbar controls no longer overlap end to end.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
1 participant
Description
Linked Issue
ready-to-implement.Screenshots / Videos
Not included; this is a Windows titlebar spacing fix validated with layout regression coverage and a Windows-target check.
Testing
cargo test -p warp traffic_lightscargo fmt -- --checkgit diff --checkcargo check -p warp --lib --target x86_64-pc-windows-gnu --testscargo clippy -p warp --lib --all-features -- -D warnings