Add Codex local child harness support#10176
Merged
Conversation
Co-Authored-By: Oz <[email protected]>
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Overview
This PR adds Codex as a supported local child harness and updates launch normalization, command construction, and tests.
Concerns
- Codex local launches reuse the shared third-party harness environment preparation path, which has persistent side effects intended for managed harness setup rather than inheriting local session state.
Security
- The Codex prep path can read
OPENAI_API_KEYfrom the Warp process environment and persist it to~/.codex/auth.json, and it rewrites~/.codex/config.tomlfor local launches.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
cephalonaut
approved these changes
May 5, 2026
Contributor
cephalonaut
left a comment
cephalonaut
left a comment
There was a problem hiding this comment.
Should fix that global state rewrite issue, but otherwise, looks good.
Co-Authored-By: Oz <[email protected]>
Co-Authored-By: Oz <[email protected]>
Co-Authored-By: Oz <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add Codex as a supported local child-agent harness in the Warp client.
This updates local harness normalization and launch command construction, and wires the CLI parsing and test coverage needed for local child launches.
This is the client-side counterpart to https://github.com/warpdotdev/warp-server/pull/10880.
Linked Issue
https://linear.app/warpdotdev/issue/QUALITY-578/codex-support-for-orchestration
ready-to-specorready-to-implement.Testing
cargo +1.92.0 fmt --allMACOSX_DEPLOYMENT_TARGET=10.14 cargo +1.92.0 clippy --workspace --exclude warp_completer --all-targets --tests -- -D warningsMACOSX_DEPLOYMENT_TARGET=10.14 cargo +1.92.0 clippy -p warp_completer --all-targets --tests -- -D warningsMACOSX_DEPLOYMENT_TARGET=10.14 cargo +1.92.0 test -p warp_cliMACOSX_DEPLOYMENT_TARGET=10.14 cargo +1.92.0 test -p warp local_child_task_config_records_supported_third_party_harnessesMACOSX_DEPLOYMENT_TARGET=10.14 cargo +1.92.0 test -p warp execute_returns_error_when_local_harness_child_requires_orchestration_v2MACOSX_DEPLOYMENT_TARGET=10.14 cargo +1.92.0 test -p warp execute_rejects_invalid_local_harness_names_before_pane_creationAgent Mode
Artifacts
CHANGELOG-OZ: Add Codex as a supported harness for local child agents.
Co-Authored-By: Oz [email protected]