Skip to content

[APP-4359] Fix remote-control chip text weight#10172

Merged
harryalbert merged 1 commit intomasterfrom
harry/app-4359-remote-control-chip-appears-bolded-in-the-toolbelt
May 5, 2026
Merged

[APP-4359] Fix remote-control chip text weight#10172
harryalbert merged 1 commit intomasterfrom
harry/app-4359-remote-control-chip-appears-bolded-in-the-toolbelt

Conversation

@harryalbert
Copy link
Copy Markdown
Contributor

@harryalbert harryalbert commented May 5, 2026

Description

Fixes the remote-control toolbar chip text weight so it matches the normal-weight agent footer display chips while preserving the shared chip fill, border, and text color styling.

Screenshots / Videos

image

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

@cla-bot cla-bot Bot added the cla-signed label May 5, 2026
@harryalbert harryalbert force-pushed the harry/app-4359-remote-control-chip-appears-bolded-in-the-toolbelt branch from 31c827a to 4bef08d Compare May 5, 2026 19:13
@harryalbert harryalbert force-pushed the harry/app-4359-remote-control-chip-appears-bolded-in-the-toolbelt branch from 4bef08d to 9309d2c Compare May 5, 2026 19:33
Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@harryalbert harryalbert requested a review from vkodithala May 5, 2026 19:39
@harryalbert harryalbert marked this pull request as ready for review May 5, 2026 19:39
@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented May 5, 2026

@harryalbert

I'm starting a first review of this pull request.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR changes the start and stop remote-control chips to use a dedicated theme that forwards the shared agent input chip background, border, text color, and contrast opt-out behavior while leaving font properties at the normal button-size default.

Concerns

  • No blocking correctness, security, or performance concerns found in the changed lines.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@harryalbert harryalbert requested a review from advait-m May 5, 2026 21:31
Copy link
Copy Markdown
Member

@advait-m advait-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@harryalbert harryalbert merged commit 6a3da8b into master May 5, 2026
42 checks passed
@harryalbert harryalbert deleted the harry/app-4359-remote-control-chip-appears-bolded-in-the-toolbelt branch May 5, 2026 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants