Use queued query UI instead of pending user query#10113
Conversation
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR switches cloud-mode initial and follow-up prompts to the queued-query UI, removes the old optimistic query rendering path, and adds grouped setup-command UI for follow-up startup commands.
Concerns
- The setup-command header can remain stuck in the running state after a cloud run fails, is cancelled, or needs auth before an exchange/harness-start event finishes the active group.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| &self.agent_view_controller, | ||
| app, | ||
| ) { | ||
| if self |
There was a problem hiding this comment.
running_group_id, but failure/cancel/auth paths never call finish_setup_command_group; if a run stops after setup commands are inserted but before an exchange or harness-start event finishes the group, this header remains visible as Running setup commands.... Finish the group on terminal failure states or keep the previous not-running guard.
## Description [Demo](https://www.loom.com/share/943140c634704c67b878b1815639aaaf) 1) Use the queued query UI for cloud mode initial query and follow-ups. Clean up old optimistic pending user query rich content machinery. 2) Properly hook setup commands for follow-up execution environment setup into the requested command-like setup command UI.
2 participants
Description
Demo