Skip to content

Gate remote server experiment enablement on windows#10079

Merged
kevinyang372 merged 1 commit intomasterfrom
kevin/properly-gate-experiment-enablement-on-windows
May 4, 2026
Merged

Gate remote server experiment enablement on windows#10079
kevinyang372 merged 1 commit intomasterfrom
kevin/properly-gate-experiment-enablement-on-windows

Conversation

@kevinyang372
Copy link
Copy Markdown
Member

@kevinyang372 kevinyang372 commented May 4, 2026

WISOTT

@cla-bot cla-bot Bot added the cla-signed label May 4, 2026
@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented May 4, 2026

@kevinyang372

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@kevinyang372 kevinyang372 requested a review from MaggieShan May 4, 2026 19:08
Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR prevents the SSH remote server experiment/control arms from enabling the remote-server feature flag or adjusting install mode on Windows, where the remote server binary is not supported.

Concerns

  • No blocking correctness or security concerns found in the changed lines.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@kevinyang372 kevinyang372 merged commit eb61300 into master May 4, 2026
37 checks passed
@kevinyang372 kevinyang372 deleted the kevin/properly-gate-experiment-enablement-on-windows branch May 4, 2026 19:26
wolverine2k pushed a commit to wolverine2k/warp that referenced this pull request May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants