fix: close cli rich input with ctrl-g from editor#10030
fix: close cli rich input with ctrl-g from editor#10030advait-m merged 2 commits intowarpdotdev:masterfrom
Conversation
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I reviewed this pull request and requested human review from: @warpdotdev/oss-maintainers. Comment Powered by Oz |
github-actions
Bot
added
the
external-contributor
|
@advait-m this fixes it and is complete |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR updates the Ctrl-G CLI agent rich input binding so it can close rich input when the embedded editor is focused, while preserving the existing terminal-context open behavior. It also adds a regression test that dispatches Ctrl-G through the focused editor responder chain and verifies the rich input session closes.
Concerns
- No blocking concerns found.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
oz-for-oss
Bot
requested review from
a team and
vkodithala
and removed request for
a team
advait-m
left a comment
advait-m
left a comment
There was a problem hiding this comment.
this is great! Thank you for the vids - super helpful!
Could you fix the failing unit test?
thread 'terminal::view::tests::ctrl_g_closes_cli_agent_rich_input_when_editor_is_focused' (55316) panicked at /home/runner/work/warp/warp/crates/warpui_core/src/core/app.rs:4614:17:
Cannot get singleton model of type "warp::settings::import::model::ImportedConfigModel" that was never registered
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Should be able to run this test specifically locally to work on this error (should just be registering the singleton model I believe - Oz should be able to handle this).
I think besides that, this is looking shippable to me - ping me if you need help re-running CI!
|
I think once CI checks are green, I can approve and we can get this in for this week's release! |
|
Good to go 🫡 |
Approved CI to re-run (late night for me, so I'll check back in morning) |
|
Congrats on your first contribution to Warp @nihalxkumar - looking forward to many more! 🎉 |
|
This should be live in Thursday's Warp release |
|
I hope it improves the workflow and adoption for linux users ❤️ |
for sure!! |
2 participants
Description
Fixes #9286 - Ctrl-G now closes CLI agent rich input when dispatched from the focused editor context. Previously the keybinding only matched the terminal context, so rich input couldn't be closed with Ctrl-G when the editor was focused.
This issue was reproduced on Arch Linux based system. The issue wasn't reproducible on MacOS.
Linked Issue
ready-to-specorready-to-implement.Screenshots / Videos
Before:
warp-richinput-amp.webm
After:
warp-ctrlg-fix.webm
Testing
Added regression test
ctrl_g_closes_cli_agent_rich_input_when_editor_is_focused()that verifies Ctrl-G closes rich input when dispatched from the focused editor context.Agent Mode
CHANGELOG-BUG-FIX: Fixed Ctrl-G not closing CLI agent rich input on linux when editor is focused (fixes #9286)