fix: add horizontal scroll to rendered markdown code blocks by yingxuel · Pull Request #10008 · warpdotdev/warp

yingxuel · 2026-05-04T05:16:16Z

Description

Rendered markdown code blocks in the notebook file view were silently clipped at the pane edge with no affordance to reach overflowing content. Switching to Raw mode showed a horizontal scrollbar; Rendered mode had none.

Root cause: RenderableRunnableCommand drew paragraphs directly to the scene with no clip layer and no scroll state. Monospace code lines wider than the container extended past the right edge and were swallowed by the outer editor clip. (RenderableTable already has a full horizontal-scroll implementation; this brings code blocks to parity.)

Changes:

crates/editor/src/render/element/paint.rs — adds draw_paragraph_scrolled, which temporarily increments RenderContext::nested_horizontal_scroll so that content_to_screen shifts text, selection highlights, cursors, and syntax-highlight decorations together under the scroll offset.
crates/editor/src/render/element/runnable_command.rs — tracks scroll_left, natural_width, viewport_bounds, scrollbar, scrollbar_hovered, and scrollbar_drag; wraps code content in a BoundedByActiveLayerAnd clip layer; renders a horizontal scrollbar thumb (reusing the table scrollbar colours from the active theme); handles shift-scroll / horizontal trackpad and scrollbar drag in dispatch_event, mirroring RenderableTable.
10 unit tests covering: max-scroll arithmetic (fits / exact / overflow), ScrollData construction, delta gating (plain vertical → None, shift-scroll and horizontal trackpad → Some), line-multiplier scaling for imprecise scroll, and scroll_left clamping at both edges.

Linked Issue

Fixes #9089

The linked issue is labeled ready-to-spec or ready-to-implement.
Where appropriate, screenshots or a short video of the implementation are included below (especially for user-visible or UI changes).

Screenshots / Videos

recording_9089.mov

Testing

Added 10 unit tests in runnable_command.rs (see code_block_scroll_tests module); all pass with cargo nextest run -p warp_editor.
Full warp_editor suite: 422/422 pass, zero regressions.
Note on presubmit: 6 tests were already failing on master before this branch was created (verified by checking out master without these changes). These failures are pre-existing and unrelated to this PR.

Agent Mode

Warp Agent Mode - This PR was created via Warp's AI Agent Mode

CHANGELOG-BUG-FIX: Rendered markdown code blocks now scroll horizontally when content overflows the pane width, matching Raw mode behaviour.

…ev#9089) Code blocks in the rendered-markdown notebook view were silently clipped at the pane edge with no way to reach overflowing content. Raw mode already had a horizontal scrollbar; this brings rendered mode to parity. Root cause: `RenderableRunnableCommand` drew paragraphs with no clip layer and no scroll state, so text wider than the container was painted off-screen and swallowed by the outer editor clip. Changes: - `paint.rs`: add `draw_paragraph_scrolled` which temporarily increments `RenderContext::nested_horizontal_scroll` so that `content_to_screen` shifts text, selection, cursors, and decorations together. - `runnable_command.rs`: track `scroll_left`, `natural_width`, `viewport_bounds`, `scrollbar`, `scrollbar_hovered`, and `scrollbar_drag`; paint a `BoundedByActiveLayerAnd` clip layer around code content; render a horizontal scrollbar thumb (same colours as the table scrollbar); handle shift-scroll / horizontal trackpad gesture and scrollbar drag in `dispatch_event` — mirroring `RenderableTable`. - 10 unit tests covering max-scroll arithmetic, scroll data, delta gating (vertical vs shift/horizontal vs precise), line-multiplier scaling, and scroll-left clamping. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>

oz-for-oss · 2026-05-04T05:16:29Z

@yingxuel

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

oz-for-oss

Overview

This PR adds nested horizontal scrolling and scrollbar handling for rendered markdown runnable code blocks.

Concerns

The new scroll offset only affects painting/event dispatch inside RenderableRunnableCommand; model-level hit testing for code blocks still uses unscrolled coordinates, so clicks, selection, cursor placement, and link hover can target the wrong text after horizontal scrolling.

Verdict

Found: 0 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

…esting Moves `scroll_left` from the `RenderableRunnableCommand` struct into `BlockItem::RunnableCodeBlock` (as `Cell<Pixels>`, matching the table pattern) so that hit-testing code paths — `character_bounds` and `coordinate_to_location` — can account for horizontal scroll when resolving clicks, selections, and link hovers inside scrolled code blocks. Also strengthens types from `f32` to `Pixels` throughout, and moves scroll clamping from `paint()` to `layout()` so it runs before the scene is built. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>

yingxuel · 2026-05-04T17:12:07Z

/oz-review

oz-for-oss · 2026-05-04T17:12:20Z

@yingxuel

I'm re-reviewing this pull request in response to a review request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

oz-for-oss

Overview

This adds per-code-block horizontal scroll state, clipping, scrollbar painting, and adjusted hit-testing for rendered markdown code fences.

Concerns

The new code-block clip layer is not marked click-through, unlike the table implementation it mirrors. That can make the layer cover the rich-text content for pointer hit-testing and break selecting/clicking inside code blocks.

Verdict

Found: 0 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Co-authored-by: oz-for-oss[bot] <277970191+oz-for-oss[bot]@users.noreply.github.com>

yingxuel · 2026-05-04T17:28:44Z

/oz-review

oz-for-oss · 2026-05-04T17:28:58Z

@yingxuel

I'm re-reviewing this pull request in response to a review request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

oz-for-oss

Overview

This PR adds horizontal overflow clipping, scroll state, scrollbar rendering, event handling, and hit-testing updates for rendered markdown code blocks.

Concerns

Scrollbar drag interaction state is stored on the renderable block, which is rebuilt during layout after notifications, so the thumb drag can be lost immediately after mouse down.

Verdict

Found: 0 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Moves scrollbar drag and hover state out of RenderableRunnableCommand and into BlockItem::RunnableCodeBlock (as CodeBlockScrollbarInteractionState with Cell<> interior mutability), mirroring LaidOutTable's pattern. This ensures drag state survives layout rebuilds triggered by ctx.notify(), fixing scrollbar dragging which previously lost its drag anchor on the first notify() call. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>

yingxuel · 2026-05-06T07:17:04Z

/oz-review

oz-for-oss · 2026-05-06T07:17:19Z

@yingxuel

I'm re-reviewing this pull request in response to a review request.

You can view the conversation on Warp.

I reviewed this pull request and requested human review from: @kevinyang372.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Oz no longer requests changes for this pull request after the latest automated review.

oz-for-oss

Overview

This PR adds horizontal scrolling support for rendered markdown code blocks by clipping code block content, shifting paragraph rendering and hit-testing with a nested horizontal scroll offset, and adding scrollbar interaction handling aligned with the existing table behavior.

Concerns

No blocking correctness or security concerns found in the annotated diff.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

kevinyang372

@yingxuel I am not sure if I quite understand this fix. You mentioned this PR adds horizontal scroll to rendered markdown code blocks but the demo shows scrolling in markdown tables (which already has horizontal scrolling)

Also I think using horizontal scrolling to the content overflow problem is the wrong solution (it is supposed to softwrap, not scroll). I would fix the content overflow itself

cla-bot Bot added the cla-signed label May 4, 2026

github-actions Bot added the external-contributor Indicates that a PR has been opened by someone outside the Warp team. label May 4, 2026

oz-for-oss Bot previously requested changes May 4, 2026

View reviewed changes

Comment thread crates/editor/src/render/element/runnable_command.rs Outdated

oz-for-oss Bot previously requested changes May 4, 2026

View reviewed changes

Comment thread crates/editor/src/render/element/runnable_command.rs

Update crates/editor/src/render/element/runnable_command.rs

79badff

Co-authored-by: oz-for-oss[bot] <277970191+oz-for-oss[bot]@users.noreply.github.com>

oz-for-oss Bot previously requested changes May 4, 2026

View reviewed changes

Comment thread crates/editor/src/render/element/runnable_command.rs Outdated

oz-for-oss Bot reviewed May 6, 2026

View reviewed changes

oz-for-oss Bot requested a review from kevinyang372 May 6, 2026 07:25

kevinyang372 requested changes May 6, 2026

View reviewed changes

Conversation

yingxuel commented May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Linked Issue

Screenshots / Videos

Testing

Agent Mode

Uh oh!

oz-for-oss Bot commented May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oz-for-oss Bot left a comment

Choose a reason for hiding this comment

Overview

Concerns

Verdict

Uh oh!

Uh oh!

yingxuel commented May 4, 2026

Uh oh!

oz-for-oss Bot commented May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oz-for-oss Bot left a comment

Choose a reason for hiding this comment

Overview

Concerns

Verdict

Uh oh!

Uh oh!

yingxuel commented May 4, 2026

Uh oh!

oz-for-oss Bot commented May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oz-for-oss Bot left a comment

Choose a reason for hiding this comment

Overview

Concerns

Verdict

Uh oh!

Uh oh!

yingxuel commented May 6, 2026

Uh oh!

oz-for-oss Bot commented May 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oz-for-oss Bot left a comment

Choose a reason for hiding this comment

Overview

Concerns

Verdict

Uh oh!

kevinyang372 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

yingxuel commented May 4, 2026 •

edited

Loading

oz-for-oss Bot commented May 4, 2026 •

edited

Loading

oz-for-oss Bot commented May 4, 2026 •

edited

Loading

oz-for-oss Bot commented May 4, 2026 •

edited

Loading

oz-for-oss Bot commented May 6, 2026 •

edited

Loading