Here's what I found while triaging this issue:

This appears to be an implementation/performance request rather than a user-facing repro report. The current find path is consistent with synchronous work that can stall on large terminal or AI histories.

Maintainer details

I concluded that blocklist find currently runs synchronously across terminal and AI block content, so this is an actionable performance enhancement to move that work off the UI thread..

Triage summary

This is an implementation/performance issue to make blocklist find asynchronous. Current terminal find runs synchronously from the find bar update path, and blocklist traversal includes both terminal command/output grids and registered rich-content views such as AI blocks.

Reproducibility

Medium. No concrete reporter steps or history sizes are provided, but the current code path confirms that find work happens synchronously and scales with the amount of terminal and AI-block content being searched.

Likely root cause

TerminalView::run_find calls TerminalFindModel::run_find directly from the view update path. In blocklist mode, run_find_on_block_list traverses visible block-height items, searches terminal grids via run_find_on_block, and invokes each rich content view's run_find. AIBlock::run_find then scans input/output text sections and updates FindState inline. This should likely become an async, cancellable search pipeline that snapshots needed search data off the UI thread and applies the latest completed results back to the model.

Relevant files

app/src/terminal/view.rs
app/src/terminal/find/model.rs
app/src/terminal/find/model/block_list.rs
app/src/terminal/find/model/rich_content.rs
app/src/ai/blocklist/block/find.rs
app/src/code_review/find_model.rs (existing async find pattern for reference)

Duplicate check

Repository-wide open issue enumeration found #9757 (Async blocklist search) as a closely related existing issue, but no second distinct likely duplicate candidate. Per the workflow's duplicate threshold, duplicate_of is left empty.

This is my automated analysis and may be incorrect. A maintainer will verify the details.

Implement async find for the blocklist #9803

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions