-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Image cache is not getting cleared #9789
Copy link
Copy link
Open
Labels
area:editor-notebooksEditors, notebooks, markdown rendering, LSP, and code display.Editors, notebooks, markdown rendering, LSP, and code display.area:performance:memoryMemory usage, allocation, leaks, and memory-bound performance.Memory usage, allocation, leaks, and memory-bound performance.area:ui-frameworkCore Warp UI framework, rendering, layout, and windowing infrastructure.Core Warp UI framework, rendering, layout, and windowing infrastructure.bugSomething isn't working.Something isn't working.repro:highThe report includes enough evidence that the issue appears highly reproducible.The report includes enough evidence that the issue appears highly reproducible.triagedIssue has received an initial automated triage pass.Issue has received an initial automated triage pass.warp:prioritizedIssues prioritized by the Warp team.Issues prioritized by the Warp team.
Milestone
Metadata
Metadata
Assignees
Labels
area:editor-notebooksEditors, notebooks, markdown rendering, LSP, and code display.Editors, notebooks, markdown rendering, LSP, and code display.area:performance:memoryMemory usage, allocation, leaks, and memory-bound performance.Memory usage, allocation, leaks, and memory-bound performance.area:ui-frameworkCore Warp UI framework, rendering, layout, and windowing infrastructure.Core Warp UI framework, rendering, layout, and windowing infrastructure.bugSomething isn't working.Something isn't working.repro:highThe report includes enough evidence that the issue appears highly reproducible.The report includes enough evidence that the issue appears highly reproducible.triagedIssue has received an initial automated triage pass.Issue has received an initial automated triage pass.warp:prioritizedIssues prioritized by the Warp team.Issues prioritized by the Warp team.
We have two caches that are used to cache images. The
AssetCacheand theImageCache. TheImageCachekey is(asset id, size), so we are storing one copy of the image for each size that we have computed.This can get kind of zany when dragging to resize the window with an image in the Markdown viewer. This will compute many, many sizes of the image and store in the
ImageCache.There is still only one copy in the
AssetCache, though, and images are only ever removed from either cache when the size of theAssetCacheis over 320MB. Resizing does not affect this size, so theImageCachetends to fill unbounded.Linear: APP-3877