-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Address Moira's review comments on left panel shortcut PR (warp-external#908) #9760
Copy link
Copy link
Open
Labels
area:settings-keybindingsSettings UI, preferences, keybindings, and keyboard-shortcut management.Settings UI, preferences, keybindings, and keyboard-shortcut management.area:warp-driveWarp Drive objects, sync, sharing, cloud object management, and persisted artifacts.Warp Drive objects, sync, sharing, cloud object management, and persisted artifacts.bugSomething isn't working.Something isn't working.os:macmacOS-specific behavior, regressions, or requests.macOS-specific behavior, regressions, or requests.repro:highThe report includes enough evidence that the issue appears highly reproducible.The report includes enough evidence that the issue appears highly reproducible.triagedIssue has received an initial automated triage pass.Issue has received an initial automated triage pass.warp:prioritizedIssues prioritized by the Warp team.Issues prioritized by the Warp team.
Metadata
Metadata
Assignees
Labels
area:settings-keybindingsSettings UI, preferences, keybindings, and keyboard-shortcut management.Settings UI, preferences, keybindings, and keyboard-shortcut management.area:warp-driveWarp Drive objects, sync, sharing, cloud object management, and persisted artifacts.Warp Drive objects, sync, sharing, cloud object management, and persisted artifacts.bugSomething isn't working.Something isn't working.os:macmacOS-specific behavior, regressions, or requests.macOS-specific behavior, regressions, or requests.repro:highThe report includes enough evidence that the issue appears highly reproducible.The report includes enough evidence that the issue appears highly reproducible.triagedIssue has received an initial automated triage pass.Issue has received an initial automated triage pass.warp:prioritizedIssues prioritized by the Warp team.Issues prioritized by the Warp team.
Track follow-ups from Moira's review on warp-external#908 — "Fix stale View menu shortcut when left panel is hidden".
Review comments to address
1. Logic refactor —
app/src/app_menus.rs:1189(inline comment)Rework the fix so the View menu simply reflects the current binding rather than special-casing the "no keystroke" case. See Moira's linked agent conversation for potential solutions.
2. Add
Left Panel: Warp Drivemenu item (review comment)Even though
Driveis its own top-level menu entity, add aLeft Panel: Warp Driveentry in the View menu alongside the other left-panel toggles for consistency.Linear: APP-4184