Skip to content

Shift+Tab conflict between history menu tab cycling and workflows arg navigation #10042

@peicodes

Description

@peicodes

Feedback reports a keybinding conflict where Shift+Tab behavior in the history menu conflicts with workflows argument cycling behavior.

Feedback text:
"shift-tab to cycle tabs in the history menu is conflicting with workflows' shift tab to cycle thru args behavior"

Slack message: https://warpdev.slack.com/archives/C08KTPNQN65/p1776091018942549

Repro:

  1. Run a workflow that has args
  2. Type the up arrow to open the history
  3. try to cycle with shift+tab

Current behavior: shift+tab now always cycles through All -> Commands -> Prompts in the history menu.

Expected behavior: if a workflow with arguments is selected, shift-tab should move the cursor and selection through the workflow's arguments instead of cycling through All -> Commands -> Prompts in the history menu. When the user selects a different item using the up/down arrows, shift-tab should behave according to the selected item: cycling through the arguments if there are any, otherwise cycling through All -> Commands -> Prompts in the history menu.

To ensure the correct precedence has been implemented, write a test for this change that populates the history menu with artificial workflow and non-workflow entries, then issues keypresses to the view and ensures the cursor and buffer contents match the expected behavior. Don't forget to test the edge cases of workflows with no arguments or only one argument.


Linear: APP-4023

Metadata

Metadata

Assignees

Labels

warp:prioritizedIssues prioritized by the Warp team.

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions