-
Notifications
You must be signed in to change notification settings - Fork 632
Support blocks feature for trzsz-ssh ( tssh ) in search mode #3960
Copy link
Copy link
Closed
Labels
FEATUREFeature RequestsFeature Requests
Description
Discord username (optional)
No response
Describe the solution you'd like?
In the shell function is_interactive_ssh_session,
change [[ ${#ARGS[@]} -ne 1 ]] to [[ ${#ARGS[@]} -ne 1 ]] && [[ $(command ssh -V 2>&1) != "trzsz ssh"* ]]:
is_interactive_ssh_session () {
ARGS=()
# ...
if [[ ${#ARGS[@]} -ne 1 ]] && [[ $(command ssh -V 2>&1) != "trzsz ssh"* ]]
then
return 1
fi
}In the shell function warp_ssh_helper, using -oRemoteCommand instead.
change command ssh -o ControlMaster=yes -o ControlPath=$SSH_SOCKET_DIR/$WARP_SESSION_ID -t "${@:1}" "..." to:
warp_ssh_helper () {
command ssh -o ControlMaster=yes -o ControlPath=$SSH_SOCKET_DIR/$WARP_SESSION_ID -t -oRemoteCommand="
export TERM_PROGRAM='WarpTerminal'
# ...
" "${@:1}"
}Is your feature request related to a problem? Please describe.
trzsz-ssh ( tssh ) supports the Warp blocks feature if ssh login directly. But it's not working in tssh search mode.
Steps to reproduce:
brew install trzsz-ssh
sudo ln -sv $(which tssh) /usr/local/bin/ssh
# It works if ssh login directly
ssh server
# It's not working in search mode. tssh will enter search mode without any argument.
ssh
# It works with an argument. e.g., there's a server alias in `~/.ssh/config` contains `s`:
ssh s
Additional context
-
BTW,
tsshsupportstrzsz ( trz / tsz )andlrzsz ( rz / sz ): lrzsz support #988 (comment)
How important is this feature to you?
3
Warp Internal (ignore) - linear-label:770f6576-d6c0-4e4f-a259-fc64b5156087
None
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
FEATUREFeature RequestsFeature Requests
