Improve logging/messaging around SSH target authentication failure#1677
Merged
Eugeny merged 6 commits intowarp-tech:mainfrom Jan 26, 2026
Merged
Improve logging/messaging around SSH target authentication failure#1677Eugeny merged 6 commits intowarp-tech:mainfrom
Eugeny merged 6 commits intowarp-tech:mainfrom
Conversation
LarsSven
commented
Jan 20, 2026
Contributor
Author
|
@Eugeny would you perhaps have an idea on how to best solve the async issue in this PR where the two flows race? Since I'm not sure if the 100ms delay is a very clean solution to this problem (though it's definitely an improvement over not receiving the message at all) |
Member
|
I've spent an hour trying to figure out a clean way to make the session wait for service output events and decided that the 100ms sleep is worth it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, it is quite opaque when Warpgate fails to authenticate with an SSH target (So this is talking about the Warpgate -> Target SSH connection and not the Client -> Warpgate SSH connection). The following happens:
Auth failedis printed to the logThis can be both hard to understand when you're initially experimenting/setting up Warpgate and make mistakes with authentication, and creates a suboptimal user experience when a user of Warpgate SSHes into the VM and then accidentally deletes the public key of the Warpgate user (which unfortunately happens a bit too often with our users).
This MR makes the following changes:
This is how it looks to the user when warpgate cannot connect to the SSH target now:

Resolves #1667