fix: generate SSO login return URL based on request host#1661
Merged
Eugeny merged 1 commit intowarp-tech:mainfrom Jan 12, 2026
Merged
Conversation
Member
|
Looks like I've missed it originally - that's the way it's supposed to work, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change modifies how the SSO return URL is generated during the login process so that it takes into account the incoming request and its specific host.
By doing this, we could reach a possible solution to support multiple independent HTTP sessions without interfering with the original behavior that enables cookie sharing across domains (see #1553, #1626 and comment #1626 (comment)).
Additionally, this approach appears to be the correct one, since during the SSO logout process the return URL construction already takes the request into account.
warpgate/warpgate-protocol-http/src/api/sso_provider_list.rs
Lines 303 to 317 in 0872234
I’m open to feedback and discussion on whether this is the most appropriate solution, and I’m happy to adapt the implementation if a better approach is suggested.