Correctly naturally sort all relevant lists in the UI#1656
Merged
Eugeny merged 2 commits intowarp-tech:mainfrom Jan 7, 2026
Merged
Correctly naturally sort all relevant lists in the UI#1656Eugeny merged 2 commits intowarp-tech:mainfrom
Eugeny merged 2 commits intowarp-tech:mainfrom
Conversation
910eb39 to
65412e2
Compare
65412e2 to
77170a2
Compare
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1645 tried to naturally sort the UI to make the ordering of the targets more intuitive. This however didn't work / wasn't complete for various reasons:
compareis a comparison function factory, not a comparison function, so the way it was called in that PR didn't actually work and as such nothing changed in the sorting order. It still sorted the targets lexicographicallyThis PR fixes these issues. I cannot guarantee this PR found all instances that would be good to naturally sort, but I did test all changes against a local warpgate instance that had data that would benefit from both sorting within groups and between groups