Skip to content

Correctly naturally sort all relevant lists in the UI#1656

Merged
Eugeny merged 2 commits intowarp-tech:mainfrom
LarsSven:ls/natural-sort
Jan 7, 2026
Merged

Correctly naturally sort all relevant lists in the UI#1656
Eugeny merged 2 commits intowarp-tech:mainfrom
LarsSven:ls/natural-sort

Conversation

@LarsSven
Copy link
Copy Markdown
Contributor

@LarsSven LarsSven commented Jan 6, 2026

#1645 tried to naturally sort the UI to make the ordering of the targets more intuitive. This however didn't work / wasn't complete for various reasons:

  • compare is a comparison function factory, not a comparison function, so the way it was called in that PR didn't actually work and as such nothing changed in the sorting order. It still sorted the targets lexicographically
  • The PR only naturally sorted targets within a group, but did not naturally sort between groups
  • Dropdown boxes for targets also need to be naturally sorted.
  • Various other resources like roles, server groups and users within the admin UI were not included in that PR, but could also be naturally sorted.

This PR fixes these issues. I cannot guarantee this PR found all instances that would be good to naturally sort, but I did test all changes against a local warpgate instance that had data that would benefit from both sorting within groups and between groups

@Eugeny Eugeny merged commit c727129 into warp-tech:main Jan 7, 2026
14 checks passed
@Eugeny
Copy link
Copy Markdown
Member

Eugeny commented Jan 7, 2026

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants