Undo API-incompatible TlsMode change#1648
Merged
Eugeny merged 3 commits intowarp-tech:mainfrom Jan 5, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the LDAP user sync PR (#1603), the API of the TlsMode enum was changed from capitalised to non-capitalised (e.g. you now need to specify "disabled" rather than "Disabled"). This breaks all API tools including Terraform in Warpgate 0.19.0, where the official Warpgate Terraform provider is now unusable since it enforces you to choose between Preferred, Disabled or Required, and doesn't allow the lowercase variant, which makes it impossible to create an HTTP target for us.
Of course the Terraform provider can be updated, but I don't see the reason to have this be lowercase, especially since all other enums in the Warpgate API are capitalised (e.g. TargetGroup.color = Primary, Secondary etc...), so this PR proposes to revert the api-breaking change.
If this is indeed accepted, it would be incredibly useful to have a 0.19.1 patch release, such that we don't end up with a situation where 0.18 has a certain API, 0.19 has an API-breaking change, and then 0.20 has the old 0.18 API again.