Merged
Conversation
Contributor
Author
|
I'm not sure what to do with the failing CI job, it timed out it seems? Is it a flaky test? |
Contributor
Author
|
@Eugeny would you have time to review this? |
Member
|
Sorry for the delay - LGTM, I've changed the CLI interface to take --options and added an option to pass the password via an environment variable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a CLI command to create a user in warpgate. This command takes the following arguments:
This command is then also used by the setup command to simplify the setup command quite a lot (which is quite nice as the setup command is very large).
Our main use case is to create an admin user directly from the CLI, so we would use it like:
I am not very familiar with rust so I may have made some supoptimal decisions around pass-by-value/cloning vs pass-by-reference, please let me know if that part especially looks reasonable.
Resolves #1505