Bugfix: clicking on a task label now checks the checkbox#34
Merged
HelpfulSoft1207 merged 1 commit intowarframe-tools:mainfrom Jan 27, 2026
Merged
Bugfix: clicking on a task label now checks the checkbox#34HelpfulSoft1207 merged 1 commit intowarframe-tools:mainfrom
HelpfulSoft1207 merged 1 commit intowarframe-tools:mainfrom
Conversation
Collaborator
|
This was intended because clicking on a collapsible makes it collapse (or expand). What happens if you click on a collapsible task with this change? |
Contributor
Author
|
Collapsibles aren't |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expected behavior: clicking on a task label will check its checkbox.
Actual behavior: nothing happens.
Setting the
forattribute on the label does exactly the same thing as the customclickevent listener (toggle the checkbox), so the two methods are cancelling each other out. Simply deleting the event listener solves the issue.