refactor: modernize build system#175
Merged
Merged
Conversation
- Modernize CMake configuration using CMakePresets.json - Integrate vcpkg package management as submodule - Switch to Visual Studio 2022 generator for Windows builds - Simplify and standardize build presets across platforms - Clean up GitHub Actions workflow configuration This change modernizes the build system with better cross-platform support. It introduces vcpkg for package management and uses CMakePresets.json for a more standardized build configuration approach.
Contributor
Author
|
##168 (comment)
-> New：
在更新到lukka/run-cmake@v10后，
PS: 没有将Windows同步使用 Ninja generator，是因为目前还存在一些没有排查出的错误，ci流程跑不通，排查清楚后可能会根据需要统一全平台的generator |
xujiajiadexiaokeai
marked this pull request as ready for review
February 8, 2025 04:04
Owner
|
感谢！可以提 MR 直接merge到 master，这样可以跑 CI |
Owner
|
我之前那个编译流程在多个平台上做的确实比较 trick |
wangfenjin
reviewed
Feb 8, 2025
| @@ -294,9 +305,11 @@ jobs: | |||
| with: | |||
| allow_failure: true | |||
| files: "${{ github.workspace }}/../../_temp/macos/src/libsimple.dylib, ${{ github.workspace }}/../../_temp/macos/test/dict/jieba.dict.utf8" | |||
Owner
There was a problem hiding this comment.
我当时这么写是因为各个平台上路径不一样
不知道现在新版的有没有什么方法能获取到这些编译产出
Owner
There was a problem hiding this comment.
另外你也可以关注下最后 so 文件的大小，之前是在 5M 左右；如果大小没怎么变应该产出就没问题
Owner
There was a problem hiding this comment.
最近也在看 bazel 不过感觉跟 cmake 比也是差不多，c++ 的编译环境实在是太差了
Contributor
Author
There was a problem hiding this comment.
好的，我看一下路径的问题。
产出我昨天ci跑下来都在5M左右，应该没什么问题，我稍后再打开测试一下
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change modernizes the build system with better cross-platform support. It introduces vcpkg for package management and uses CMakePresets.json for a more standardized build configuration approach.