Skip to content

Commit f79c5a6

Browse files
iskakaushikwandyers
authored andcommitted
[fuchsia] Remove log dumping to prevent timeouts (flutter-team-archive#18409)
See: flutter/flutter#57273
1 parent acef255 commit f79c5a6

1 file changed

Lines changed: 16 additions & 12 deletions

File tree

‎testing/fuchsia/run_tests.sh‎

Lines changed: 16 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -37,12 +37,14 @@ else
3737
fi
3838

3939
reboot() {
40-
echo "Dumping system logs..."
40+
# TODO come up with better log collection strategy.
41+
# https://github.com/flutter/flutter/issues/57273
42+
# echo "Dumping system logs..."
4143

42-
./fuchsia_ctl -d $device_name ssh \
43-
-c "log_listener --dump_logs yes" \
44-
--timeout-seconds $ssh_timeout_seconds \
45-
--identity-file $pkey
44+
# ./fuchsia_ctl -d $device_name ssh \
45+
# -c "log_listener --dump_logs yes" \
46+
# --timeout-seconds $ssh_timeout_seconds \
47+
# --identity-file $pkey
4648

4749
echo "$(date) START:REBOOT ------------------------------------------"
4850
# note: this will set an exit code of 255, which we can ignore.
@@ -102,15 +104,17 @@ echo "$(date) START:fml_tests ---------------------------------------"
102104
--identity-file $pkey \
103105
--timeout-seconds $test_timeout_seconds \
104106
--packages-directory packages
107+
echo "$(date) DONE:fml_tests ---------------------------------------"
105108

106109

107-
#echo "$(date) START:flow_tests --------------------------------------"
108-
#./fuchsia_ctl -d $device_name test \
109-
# -f flow_tests-0.far \
110-
# -t flow_tests \
111-
# --identity-file $pkey \
112-
# --timeout-seconds $test_timeout_seconds \
113-
# --packages-directory packages
110+
echo "$(date) START:flow_tests --------------------------------------"
111+
./fuchsia_ctl -d $device_name test \
112+
-f flow_tests-0.far \
113+
-t flow_tests \
114+
--identity-file $pkey \
115+
--timeout-seconds $test_timeout_seconds \
116+
--packages-directory packages
117+
echo "$(date) DONE:flow_tests ---------------------------------------"
114118

115119

116120
# TODO(kaushikiska): Runtime and shell tests are failing with

0 commit comments

Comments
 (0)