Skip to content

Update PluginConfig.cs - Fix null reference#30

Merged
walterpg merged 2 commits intowalterpg:masterfrom
Rookiestyle:patch-1
Feb 1, 2021
Merged

Update PluginConfig.cs - Fix null reference#30
walterpg merged 2 commits intowalterpg:masterfrom
Rookiestyle:patch-1

Conversation

@Rookiestyle
Copy link
Copy Markdown
Contributor

@Rookiestyle Rookiestyle commented Feb 1, 2021

Fixes #29

Method UpdateConfig dumps because of configVer = new Version(ConfigVersion);
ConfigVersion is null, if GoogleSync.ConfigVersion can be read in method InitLegacyDefault

@walterpg walterpg mentioned this pull request Feb 1, 2021
Copy link
Copy Markdown
Owner

@walterpg walterpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch. Thanks for finding this.

I doubt this has anything to do with #27 though, since this is new code in 4.0.4-beta.

@Rookiestyle
Copy link
Copy Markdown
Contributor Author

My bad, it's reworked now and I also removed the link to #27

Copy link
Copy Markdown
Owner

@walterpg walterpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was quick! Thanks.

@walterpg walterpg merged commit 6140ada into walterpg:master Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug Report - 4.0.4beta

2 participants