Repository navigation
Fix CLI yargs import on Node 22+ and add option integration test - #50
Merged
maxnachlinger merged 1 commit intoNov 11, 2026
Merged
Conversation
Contributor
Author
|
Hi, a gentle check-in on this one. It is a one-line fix for the Node 22+ crash in #49, and the integration test passes with it. Is there anything else you would like changed before it can be merged? |
Contributor
|
Forgive the late reply, this repo is not been used in years and has not been well maintained. We've found Rust to be a good fit for the scale at which we operate via a vis GraphQL. 🙂 Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #49.
Problem
In
app.js,const yargs = require("yargs/yargs");references./yargswithout a file extension fromyargspackage exports. In Node 22+, requiring extensionless subpath exports triggers the ESM loader, which crashes with:This causes
cat test/fixtures/complex.json | node app.jsto crash, andtest/integration.spec.jsfails with empty stdout.Solution
require("yargs/yargs")torequire("yargs")inapp.js, which resolves toindex.cjsvia the package root export.test/integration.spec.jsasserting that CLI options (--baseType,--prefix) are accepted and produce the expected schema.Local verification