Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1673 +/- ##
============================================
- Coverage 50.22% 50.21% -0.01%
Complexity 12651 12651
============================================
Files 1365 1365
Lines 85191 85191
Branches 14726 14726
============================================
- Hits 42785 42782 -3
- Misses 37608 37610 +2
- Partials 4798 4799 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
liblit
left a comment
liblit
left a comment
There was a problem hiding this comment.
No substantive code fixes required for this update!
Nice!
|
Looks like I spoke too soon. Everything passes on my Mac but something is up on Linux... |
This reverts commit cf6e1ce.
|
FYI, I have an upgrade for Gradle 9.1.0 in the works. Should be ready for you to review later today. |
|
@liblit had to do some fixes here, so needs another review |
|
Note that the repository still thinks that "JDK 24 on ubuntu-latest" is required before merging to the |
Fixed! We now require the JDK 25 job to pass. |
2 participants
As usual, we just test that previous Java bytecode support works, but can't promise support for new features.
We needed a couple of code changes on this one. First, apparently
new File("").exists()returns true on JDK 25 (??). Not sure why we were doing that before anyway; we fix up the Dalvik test code to just passnull(and annotate a couple of methods to indicate that's legal).Second, the
TestListIteratorslicer test stopped running in reasonable time, presumably due to implementation-level changes in the JDK. We rewrite the test to be self-contained and hence robust to these internal JDK changes.Finally, due to some Gradle toolchain issues, we had to tweak the CI config to always install JDK 25, so we can use it to compile our code.