Merged
Conversation
Previously Linux jobs included ECJ compilation but macOS and Windows jobs did not. [Unfortunately, that allowed a Windows-specific ECJ compilation problem to go undetected.](wala#1518) In discussion of that fix, WALA maintainers agreed that testing ECJ on all platforms was advisable.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1666 +/- ##
=========================================
Coverage 50.20% 50.20%
Complexity 12650 12650
=========================================
Files 1365 1365
Lines 85214 85214
Branches 14733 14733
=========================================
Hits 42784 42784
Misses 37633 37633
Partials 4797 4797 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
msridhar
approved these changes
Sep 6, 2025
Contributor
|
Thanks! |
Contributor
Author
|
You're welcome, @juliandolby. And thank you for figuring out the changes needed to make ECJ on Windows actually pass, per #1518! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously Linux jobs included ECJ compilation but macOS and Windows jobs did not. Unfortunately, that allowed a Windows-specific ECJ compilation problem to go undetected. In discussion of that fix, WALA maintainers agreed that testing ECJ on all platforms was advisable.