Skip to content

Fix issue 1515#1516

Merged
msridhar merged 4 commits intowala:masterfrom
msridhar:issue-1515
May 27, 2025
Merged

Fix issue 1515#1516
msridhar merged 4 commits intowala:masterfrom
msridhar:issue-1515

Conversation

@msridhar
Copy link
Copy Markdown
Member

@msridhar msridhar commented May 27, 2025 •
edited
Loading

Fixes #1515

Replaces a castToNonNull with uncheckNull and a more flexible type variable bound.

@msridhar
Copy link
Copy Markdown
Member Author

msridhar commented May 27, 2025

@khatchad can you check that this fixes the crash you saw?

@github-actions
Copy link
Copy Markdown

github-actions bot commented May 27, 2025 •
edited
Loading

Test Results

  827 files  ±0    827 suites  ±0   5h 21m 21s ⏱️ + 31m 59s
  765 tests ±0    748 ✅ ±0   17 💤 ±0  0 ❌ ±0 
5 239 runs  ±0  5 118 ✅ ±0  121 💤 ±0  0 ❌ ±0 

Results for commit 2a7b1c9. ± Comparison against base commit 173eb9e.

♻️ This comment has been updated with latest results.

@khatchad
Copy link
Copy Markdown
Contributor

khatchad commented May 27, 2025

@khatchad can you check that this fixes the crash you saw?

Crash is gone. Thanks!

@msridhar
Copy link
Copy Markdown
Member Author

msridhar commented May 27, 2025

CI is failing due to some network issue downloading Kawa. Hopefully that'll go away soon.

@msridhar msridhar requested a review from liblit May 27, 2025 18:37
@msridhar msridhar enabled auto-merge (squash) May 27, 2025 18:37
@codecov
Copy link
Copy Markdown

codecov bot commented May 27, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 50.20%. Comparing base (173eb9e) to head (2a7b1c9).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
.../java/com/ibm/wala/util/intset/MutableMapping.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #1516      +/-   ##
============================================
- Coverage     50.20%   50.20%   -0.01%     
  Complexity    12653    12653              
============================================
  Files          1362     1362              
  Lines         85501    85502       +1     
  Branches      14739    14740       +1     
============================================
  Hits          42926    42926              
  Misses        37773    37773              
- Partials       4802     4803       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@msridhar msridhar merged commit 9336758 into wala:master May 27, 2025
17 of 22 checks passed
@msridhar msridhar deleted the issue-1515 branch May 27, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liblit liblit liblit approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

JavaViewerDriver broken

3 participants

@msridhar @khatchad @liblit