Merged
Conversation
Test Results 720 files - 107 720 suites - 107 3h 55m 10s ⏱️ - 44m 39s Results for commit 24aca4d. ± Comparison against base commit 73f26c8. This pull request removes 118 and adds 101 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Member
Author
|
One this passes review I will update the required job names for CI appropriately. |
msridhar
commented
Apr 11, 2025
liblit
reviewed
Apr 11, 2025
shrike/src/main/java/com/ibm/wala/shrike/shrikeCT/ClassReader.java
Outdated
Show resolved
Hide resolved
liblit
previously approved these changes
Apr 11, 2025
Member
Author
|
@liblit can I get another review on this one? Merged in your Gradle 8.14 update. Thanks! |
liblit
approved these changes
Apr 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1491
As usual, we verify existing tests don't crash on JDK 24 bytecodes, but we haven't added or tested support for any new features.
We update to Gradle 8.14 RC1 as that version supports running on JDK 24. We also shift to using Zulu JDK builds wherever possible. Temurin has enabled JEP 493 for their JDK 24 builds (see adoptium/temurin-build#4035) which means they are distributed without
.jmodfiles. This breaks WALA's strategy for loading Java standard library classes from the running VM if no other location is specified. We need to update the wiki to document this new requirement for JDK 24+ JVMs.