enable tests for java onepointfive#1480
Conversation
|
There are multiple similar pull requests trying to make this change, and unfortunately I cannot understand what's going on here. Could you clarify in more detail how this PR is adding new tests? I don't see any new test inputs. |
|
Hey, so we couldn't find how java onepointfive was run before so we added these in to run. cc @juliandolby |
1af5fe2 to
b510bfc
Compare
|
@jkhaliqi can we close all the outdated pull requests so we have a single open one with the relevant changes? |
b510bfc to
35ea1b2
Compare
|
@msridhar Thank you, All other PR's closed everything should be updated on this single PR. |
msridhar
left a comment
There was a problem hiding this comment.
LGTM. Eventually we should rewrite these tests to be parameterized tests rather than extracting things out from the test method name.
|
@jkhaliqi please run |
Creates ECJJava15IRTest similar to ECJJava17IRTest in order to test classes using javaonepointfive package.