Support building and running on JDK 22#1419
Merged
msridhar merged 5 commits intowala:masterfrom Jul 20, 2024
Merged
Conversation
msridhar
changed the title
liblit
reviewed
Jul 20, 2024
liblit
approved these changes
Jul 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't immediately crash on JDK 22 bytecodes, but new bytecode features have not been tested.
We modify the
TestListtest input to avoid a blowup when runningSlicerTest.testList. openjdk/jdk@b62e774 introduced calls toString.formatfromInteger.parseInt, which dramatically increased the number of reachable methods for the previous version of this test, which in turn led to very slow performance with the slicer. Changing the test to use aList<String>and string constants removes this blowup. (Whole-program analysis is fun!)Fixes #1414