Switch to ConcurrentHashMap in SeqClassHierarchyFactory#1379
Merged
msridhar merged 1 commit intowala:masterfrom Mar 21, 2024
Merged
Switch to ConcurrentHashMap in SeqClassHierarchyFactory#1379msridhar merged 1 commit intowala:masterfrom
msridhar merged 1 commit intowala:masterfrom
Conversation
liblit
approved these changes
Mar 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe this should address #1377. See 74b6c74. For some reason at that point we decided not to use the type system to enforce use of a
ConcurrentHashMapalways. In this spirit of trying not to break things I didn't do that here, but instead changedSeqClassHierarchyFactoryto useConcurrentHashMap.Fixes #1377 (though we can reopen if the crash still happens)