Skip to content

fix(deps): udpate commitlint monorepo to v12#99

Merged
jdbruijn merged 2 commits intomasterfrom
fix/deps-commitlint
Feb 24, 2021
Merged

fix(deps): udpate commitlint monorepo to v12#99
jdbruijn merged 2 commits intomasterfrom
fix/deps-commitlint

Conversation

@jdbruijn
Copy link
Copy Markdown
Collaborator

BREAKING CHANGE: Remove support for lerna v2 and change the order of the extends resolution from right-to-left to left-to-right.

Closes #97.

BREAKING CHANGE: Remove support for lerna v2 and change the order of the `extends` resolution
from right-to-left to left-to-right.

Closes #97.
@jdbruijn jdbruijn force-pushed the fix/deps-commitlint branch from 20f30f8 to 8b0b095 Compare February 24, 2021 15:07
@jdbruijn
Copy link
Copy Markdown
Collaborator Author

The tests fails on both tests that use lerna , I haven't had time to look at it yet and I'm not familiar with the tests. @wagoid could you perhaps have a look at why these tests are failing?

@jdbruijn
Copy link
Copy Markdown
Collaborator Author

Okay, had a more in-depth look and it has to do with a change in config-lerna-scopes. If I revert the following, the tests pass.

https://github.com/conventional-changelog/commitlint/pull/2149/files#diff-4f14fb88e35cc639cdad864e486fcf813d5905ce3a4df8e250acd1e0fb9a5769R21-R34

@jdbruijn
Copy link
Copy Markdown
Collaborator Author

I've got the fix too. I'll update this PR within an hour.

Copy link
Copy Markdown
Owner

@wagoid wagoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jdbruijn jdbruijn merged commit cb649cc into master Feb 24, 2021
@jdbruijn jdbruijn deleted the fix/deps-commitlint branch February 24, 2021 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

deps: update @commitlint monrepo

2 participants